addressing comment

flutter · Nov 14, 2019 · 06e42a9 · 06e42a9
1 parent 749f7b4
commit 06e42a9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/lib/ui/window/pointer_data_packet_converter.cc b/lib/ui/window/pointer_data_packet_converter.cc
@@ -23,8 +23,9 @@ std::unique_ptr<PointerDataPacket> PointerDataPacketConverter::Convert(
   // Converts each pointer data in the buffer and stores it in the
   // converted_pointers.
   for (size_t i = 0; i < buffer_length / kBytesPerPointerData; i++) {
-    PointerData pointer_data =
-        *(reinterpret_cast<PointerData*>(&buffer[i * kBytesPerPointerData]));
+    PointerData pointer_data;
+    memcpy(&pointer_data, &buffer[i * kBytesPerPointerData],
+           sizeof(PointerData));
     ConvertPointerData(pointer_data, converted_pointers);
   }
 

diff --git a/lib/ui/window/pointer_data_packet_converter_unittests.cc b/lib/ui/window/pointer_data_packet_converter_unittests.cc
@@ -88,8 +88,9 @@ void UnpackPointerPacket(std::vector<PointerData>& output,
   size_t buffer_length = buffer.size();
 
   for (size_t i = 0; i < buffer_length / kBytesPerPointerData; i++) {
-    PointerData pointer_data =
-        *(reinterpret_cast<PointerData*>(&buffer[i * kBytesPerPointerData]));
+    PointerData pointer_data;
+    memcpy(&pointer_data, &buffer[i * kBytesPerPointerData],
+           sizeof(PointerData));
     output.push_back(pointer_data);
   }
   packet.reset();