Skip to content

Commit

Permalink
Implement JSObject instead of extending (#46070)
Browse files Browse the repository at this point in the history
JSObject will have a factory constructor to create an object literal, so
you can't extend it as it will no longer have a generative constructor
(@staticInterop types can't have generative constructors).
  • Loading branch information
srujzs committed Sep 19, 2023
1 parent f1fd0a3 commit 838d0a0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/web_ui/lib/src/engine/js_interop/js_loader.dart
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ abstract class FlutterEngineInitializer{
@JS()
@anonymous
@staticInterop
abstract class FlutterAppRunner extends JSObject {
abstract class FlutterAppRunner implements JSObject {
factory FlutterAppRunner({required RunAppFn runApp,}) => FlutterAppRunner._(
runApp: (([RunAppFnParameters? args]) => futureToPromise(runApp(args))).toJS
);
Expand Down Expand Up @@ -101,7 +101,7 @@ typedef RunAppFn = Future<FlutterApp> Function([RunAppFnParameters?]);
@JS()
@anonymous
@staticInterop
abstract class FlutterApp extends JSObject {
abstract class FlutterApp implements JSObject {
/// Cleans a Flutter app
external factory FlutterApp();
}

0 comments on commit 838d0a0

Please sign in to comment.