Skip to content

Commit

Permalink
[web] Add dart:js_interop_unsafe to SDK. (#41591)
Browse files Browse the repository at this point in the history
Adds the `dart:js_interop_unsafe` library to the SDK.
  • Loading branch information
joshualitt committed May 3, 2023
1 parent 9c25f33 commit d2dce25
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 0 deletions.
10 changes: 10 additions & 0 deletions sky/packages/sky_engine/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ import("//third_party/dart/sdk/lib/isolate/isolate_sources.gni")
import("//third_party/dart/sdk/lib/js/js_annotations_sources.gni")
import("//third_party/dart/sdk/lib/js/js_sources.gni")
import("//third_party/dart/sdk/lib/js_interop/js_interop_sources.gni")
import(
"//third_party/dart/sdk/lib/js_interop_unsafe/js_interop_unsafe_sources.gni")
import("//third_party/dart/sdk/lib/js_util/js_util_sources.gni")
import("//third_party/dart/sdk/lib/math/math_sources.gni")
import("//third_party/dart/sdk/lib/typed_data/typed_data_sources.gni")
Expand Down Expand Up @@ -148,6 +150,12 @@ copy("js_interop") {
]
}

copy("js_interop_unsafe") {
lib_path = rebase_path("js_interop_unsafe", "", dart_sdk_lib_path)
sources = rebase_path(js_interop_unsafe_sdk_sources, "", lib_path)
outputs = [ "$root_gen_dir/dart-pkg/sky_engine/lib/js_interop_unsafe/{{source_file_part}}" ]
}

copy("js_util") {
lib_path = rebase_path("js_util", "", dart_sdk_lib_path)
sources = rebase_path(js_util_sdk_sources, "", lib_path)
Expand Down Expand Up @@ -207,6 +215,7 @@ group("copy_dart_sdk") {
":isolate",
":js",
":js_interop",
":js_interop_unsafe",
":js_util",
":math",
":typed_data",
Expand All @@ -231,6 +240,7 @@ generated_file("_embedder_yaml") {
" \"dart:isolate\": \"isolate/isolate.dart\"",
" \"dart:js\": \"js/js.dart\"",
" \"dart:js_interop\": \"js_interop/js_interop.dart\"",
" \"dart:js_interop_unsafe\": \"js_interop_unsafe/js_interop_unsafe.dart\"",
" \"dart:js_util\": \"js_util/js_util.dart\"",
" \"dart:math\": \"math/math.dart\"",
" \"dart:typed_data\": \"typed_data/typed_data.dart\"",
Expand Down
1 change: 1 addition & 0 deletions sky/packages/sky_engine/lib/_embedder.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ embedded_libs:
"dart:isolate": "../../../../../third_party/dart/sdk/lib/isolate/isolate.dart"
"dart:js": "../../../../../third_party/dart/sdk/lib/js/js.dart"
"dart:js_interop": "../../../../../third_party/dart/sdk/lib/js_interop/js_interop.dart"
"dart:js_interop_unsafe": "../../../../../third_party/dart/sdk/lib/js_interop_unsafe/js_interop_unsafe.dart"
"dart:js_util": "../../../../../third_party/dart/sdk/lib/js_util/js_util.dart"
"dart:math": "../../../../../third_party/dart/sdk/lib/math/math.dart"
"dart:typed_data": "../../../../../third_party/dart/sdk/lib/typed_data/typed_data.dart"
Expand Down
1 change: 1 addition & 0 deletions web_sdk/sdk_rewriter.dart
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ import 'dart:developer' as developer;
import 'dart:js_util' as js_util;
import 'dart:_js_annotations';
import 'dart:js_interop' hide JS;
import 'dart:js_interop_unsafe';
import 'dart:math' as math;
import 'dart:typed_data';
import 'dart:ui' as ui;
Expand Down
2 changes: 2 additions & 0 deletions web_sdk/test/sdk_rewriter_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ import 'dart:developer' as developer;
import 'dart:js_util' as js_util;
import 'dart:_js_annotations';
import 'dart:js_interop' hide JS;
import 'dart:js_interop_unsafe';
import 'dart:math' as math;
import 'dart:typed_data';
import 'dart:ui' as ui;
Expand Down Expand Up @@ -73,6 +74,7 @@ import 'dart:developer' as developer;
import 'dart:js_util' as js_util;
import 'dart:_js_annotations';
import 'dart:js_interop' hide JS;
import 'dart:js_interop_unsafe';
import 'dart:math' as math;
import 'dart:typed_data';
import 'dart:ui' as ui;
Expand Down

0 comments on commit d2dce25

Please sign in to comment.