Skip to content

Commit

Permalink
Regres: Drop support for tests results only on new change
Browse files Browse the repository at this point in the history
The test list from the latest patchset is now run on the parent.
Missing tests are a bug.

Change-Id: I149e235968acad4988d0fcff78d8a8796aaf118c
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/26559
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
  • Loading branch information
ben-clayton committed Mar 9, 2019
1 parent dbb94f1 commit ebefaf7
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions tests/regres/main.go
Expand Up @@ -881,14 +881,18 @@ func compare(old, new *CommitTestResults) string {

for test, new := range new.Tests {
old, found := old.Tests[test]
if !found {
log.Printf("Test result for '%s' not found on old change\n", test)
continue
}
switch {
case found && old.Status.Passing() && new.Status.Failing():
case old.Status.Passing() && new.Status.Failing():
broken = append(broken, test)
case found && old.Status.Failing() && new.Status.Passing():
case old.Status.Failing() && new.Status.Passing():
fixed = append(fixed, test)
case found && old.Status != new.Status:
case old.Status != new.Status:
changed = append(changed, test)
case found && old.Status.Failing() && new.Status.Failing():
case old.Status.Failing() && new.Status.Failing():
failing = append(failing, test) // Still broken
}
totalTests++
Expand Down

0 comments on commit ebefaf7

Please sign in to comment.