Skip to content

Commit

Permalink
Re-land "Enable unified OpenGL/Metal builds." (#17230)
Browse files Browse the repository at this point in the history
  • Loading branch information
chinmaygarde committed Mar 20, 2020
1 parent 70f6d18 commit f58967f
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions tools/gn
Expand Up @@ -44,9 +44,6 @@ def get_out_dir(args):
if args.enable_vulkan:
target_dir.append('vulkan')

if args.enable_metal and args.target_os == 'ios':
target_dir.append('metal')

return os.path.join(args.out_dir, 'out', '_'.join(target_dir))

def to_command_line(gn_args):
Expand Down Expand Up @@ -219,7 +216,8 @@ def to_gn_args(args):
gn_args['use_goma'] = False
gn_args['goma_dir'] = None

if args.enable_metal:
# Enable Metal on non-simulator iOS builds.
if args.target_os == 'ios' and not args.simulator:
gn_args['skia_use_metal'] = True
gn_args['shell_enable_metal'] = True
# Bitcode enabled builds using the current version of the toolchain leak
Expand Down Expand Up @@ -323,7 +321,6 @@ def parse_args(args):
parser.add_argument('--operator-new-alignment', dest='operator_new_alignment', type=str, default=None)

parser.add_argument('--enable-vulkan', action='store_true', default=False)
parser.add_argument('--enable-metal', action='store_true', default=False)

parser.add_argument('--enable-fontconfig', action='store_true', default=False)
parser.add_argument('--enable-skshaper', action='store_true', default=False)
Expand Down

1 comment on commit f58967f

@irontech
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

metal is not used on macOS, right?

Please sign in to comment.