Assert that all VM launches in the process have the same opinion on whether the VM should be leaked in the process. #8622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
approved these changes
Apr 17, 2019
liyuqian
approved these changes
Apr 17, 2019
…hether the VM should be leaked in the process.
chinmaygarde
force-pushed
the
leak_assert
branch
from
c7b9526
to
bbbb8da
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 18, 2019
…ion on whether the VM should be leaked in the process. (flutter/engine#8622)
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 18, 2019
flutter/engine@7679474...876c4c3 git log 7679474..876c4c3 --no-merges --oneline 876c4c3 Assert that all VM launches in the process have the same opinion on whether the VM should be leaked in the process. (flutter/engine#8622) 72c84c2 Revert "Roll src/third_party/dart 7b9ab9f353..714a082a5d (7 commits)" (flutter/engine#8624) f017fe7 Avoid manually shutting down engine managed isolates. (flutter/engine#8621) 80e934e Roll src/third_party/dart 7b9ab9f353..714a082a5d (7 commits) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (cbracken@google.com), and stop the roller if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a possibility for a VM launch to not have a requisite shutdown if a previous launch asked to leak the VM instance in the process. Embedders have to ensure (via their Embedding APIs) that all instances of VM launch use consistent settings.