Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Roll src/third_party/dart 7b9ab9f353..714a082a5d (7 commits)" #8624

Merged
merged 1 commit into from
Apr 17, 2019

Conversation

liyuqian
Copy link
Contributor

@liyuqian liyuqian commented Apr 17, 2019

Reverts #8620

Reason for the revert: breaks the post-submit Mac iOS build bot.

@liyuqian liyuqian requested a review from bkonyi April 17, 2019 23:32
@liyuqian liyuqian merged commit 72c84c2 into master Apr 17, 2019
@bkonyi
Copy link
Contributor

bkonyi commented Apr 17, 2019

RSLGTM

@bkonyi bkonyi deleted the revert-8620-dart-sdk-roll-2019-04-17 branch April 17, 2019 23:44
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 18, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Apr 18, 2019
flutter/engine@7679474...876c4c3

git log 7679474..876c4c3 --no-merges --oneline
876c4c3 Assert that all VM launches in the process have the same opinion on whether the VM should be leaked in the process. (flutter/engine#8622)
72c84c2 Revert "Roll src/third_party/dart 7b9ab9f353..714a082a5d (7 commits)" (flutter/engine#8624)
f017fe7 Avoid manually shutting down engine managed isolates. (flutter/engine#8621)
80e934e Roll src/third_party/dart 7b9ab9f353..714a082a5d (7 commits)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (cbracken@google.com), and stop
the roller if necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants