Update ExternalViewEmbedder class comment. #11063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Aug 16, 2019
|
@cbracken forgot to send the nits? |
cbracken
reviewed
Aug 26, 2019
cbracken
reviewed
Aug 26, 2019
flow/embedded_views.h
Outdated
| // Facilitates embedding of platform views within the flow layer tree. | ||
| // | ||
| // Used on iOS and on embedded platforms that provides a system compositor | ||
| // as part of the project arguments |
There was a problem hiding this comment.
End this sentence with a period.
cbracken
approved these changes
Aug 26, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 18, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Sep 18, 2019
) (#40776) git@github.com:flutter/engine.git/compare/2289072724ff...113be24 git log 2289072..113be24 --no-merges --oneline 2019-09-18 amirh@users.noreply.github.com Update ExternalViewEmbedder class comment. (flutter/engine#11063) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
) (flutter#40776) git@github.com:flutter/engine.git/compare/2289072724ff...113be24 git log 2289072..113be24 --no-merges --oneline 2019-09-18 amirh@users.noreply.github.com Update ExternalViewEmbedder class comment. (flutter/engine#11063) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.