New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add web engine screenshot (scuba) tests #12353
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditman
requested review from
mdebbar,
ferhatb,
harryterkelsen and
yjbanov
and removed request for
harryterkelsen
September 19, 2019 02:39
yjbanov
approved these changes
Sep 19, 2019
harryterkelsen
approved these changes
Sep 19, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 20, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Sep 23, 2019
git@github.com:flutter/engine.git/compare/99092a0436a2...b875c7a git log 99092a0..b875c7a --no-merges --oneline 2019-09-20 ditman@gmail.com Add web engine screenshot (scuba) tests (flutter/engine#12353) 2019-09-20 skia-flutter-autoroll@skia.org Roll src/third_party/skia 9a9841178078..ffdc3e668061 (1 commits) (flutter/engine#12369) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
git@github.com:flutter/engine.git/compare/99092a0436a2...b875c7a git log 99092a0..b875c7a --no-merges --oneline 2019-09-20 ditman@gmail.com Add web engine screenshot (scuba) tests (flutter/engine#12353) 2019-09-20 skia-flutter-autoroll@skia.org Roll src/third_party/skia 9a9841178078..ffdc3e668061 (1 commits) (flutter/engine#12369) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each separate commit in this PR shows the changes needed per test file to get it to run, after bringing all the raw source from our internal repo.
Some test output, when running these on my Linux machine:
Skipped
I had to skip a couple of compositing tests, because we can't control the size of the viewport yet, and they rely on the viewport (iframe) to be smaller than what it is right now:
Modified goldens
I needed to update the goldens that rendered text, since most of them used the font
sans-serif
(system dependant) orRoboto
(which may not exist on the system).I fixed all those instances by setting the font family to
Arial
and updated the goldens, which should be more multi-platform now... We'll see.Slightly different golden results (untouched):