Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add web engine screenshot (scuba) tests #12353

Merged
merged 11 commits into from Sep 20, 2019
Merged

Add web engine screenshot (scuba) tests #12353

merged 11 commits into from Sep 20, 2019

Conversation

ditman
Copy link
Member

@ditman ditman commented Sep 19, 2019

Each separate commit in this PR shows the changes needed per test file to get it to run, after bringing all the raw source from our internal repo.

Some test output, when running these on my Linux machine:

$ felt test -t test/golden_tests/engine/
...
00:17 +110 ~2: All tests passed!

Skipped

I had to skip a couple of compositing tests, because we can't control the size of the viewport yet, and they rely on the viewport (iframe) to be smaller than what it is right now:

  • Cull rect computation fills screen bounds
  • Cull rect computation offset overflows paint bounds

Modified goldens

I needed to update the goldens that rendered text, since most of them used the font sans-serif (system dependant) or Roboto (which may not exist on the system).

I fixed all those instances by setting the font family to Arial and updated the goldens, which should be more multi-platform now... We'll see.

Slightly different golden results (untouched):

  • misaligned_pixels_in_canvas_test.png (0.16%)
  • misaligned_canvas_test.png (0.16%)
  • bitmap_canvas_fills_color_when_transformed.png (0.21%)
  • bitmap_canvas_fills_paint_when_transformed.png (0.21%)
  • paint_bounds_for_draw_circle.png (0.0008%)
  • svg_stroke_line.png (0.0023%)
  • svg_quad_bezier.png (0.0817%)
  • svg_cubic_bezier.png (0.14%)
  • svg_arc_1.png (0.0156%)
  • svg_arc_4.png (0.0521%)
  • svg_arc_6.png (0.0523%)
  • svg_arc_7.png (0.0173%)
  • svg_arc_8.png (0.0458%)
  • compositing_shifted_clip_rrect.png (0.016%)
  • compositing_shifted_physical_shape_clip.png (0.004%)
  • compositing_3d_rotate1.png (0.116%)

@ditman ditman requested review from mdebbar, ferhatb, harryterkelsen and yjbanov and removed request for harryterkelsen September 19, 2019 02:39
@ditman ditman merged commit b875c7a into flutter:master Sep 20, 2019
@ditman ditman deleted the scuba-tests branch September 20, 2019 16:01
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 20, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Sep 23, 2019
git@github.com:flutter/engine.git/compare/99092a0436a2...b875c7a

git log 99092a0..b875c7a --no-merges --oneline
2019-09-20 ditman@gmail.com Add web engine screenshot (scuba) tests (flutter/engine#12353)
2019-09-20 skia-flutter-autoroll@skia.org Roll src/third_party/skia 9a9841178078..ffdc3e668061 (1 commits) (flutter/engine#12369)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019
git@github.com:flutter/engine.git/compare/99092a0436a2...b875c7a

git log 99092a0..b875c7a --no-merges --oneline
2019-09-20 ditman@gmail.com Add web engine screenshot (scuba) tests (flutter/engine#12353)
2019-09-20 skia-flutter-autoroll@skia.org Roll src/third_party/skia 9a9841178078..ffdc3e668061 (1 commits) (flutter/engine#12369)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants