-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Turn on RasterCache based on view hierarchy (#13360)" #13442
Conversation
This caused EmbedderTest.VerifyB143464703 to fail after merging into master. ``` ../../flutter/shell/platform/embedder/tests/embedder_unittests.cc:3111: Failure Value of: ImageMatchesFixture("verifyb143464703.png", renderered_scene) Actual: false Expected: true [ FAILED ] EmbedderTest.VerifyB143464703 (2507 ms) ``` This reverts commit 3ad3bc7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
git@github.com:flutter/engine.git/compare/5051bef17bdc...e609577 git log 5051bef..e609577 --no-merges --oneline 2019-10-30 mklim@google.com Revert "Turn on RasterCache based on view hierarchy (#13360)" (flutter/engine#13442) 2019-10-30 mklim@google.com Turn on RasterCache based on view hierarchy (flutter/engine#13360) 2019-10-30 bkonyi@google.com Roll src/third_party/dart d3a5b82355..f30b494035 (9 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC cbracken@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
The failure should have dumped both the expected image and actual image to disk and logged paths to the same. Can you attach the images to the the issue please? |
@chinmaygarde they should be there already, see flutter/flutter#38903 (comment). We should sync up to talk about this when you've got a minute, @liyuqian and I both suspect that this is an issue with the GL implementation in the test harness. The behavior doesn't repro on iOS and the visual degradation also doesn't appear to actually have to do with the cache. I could be missing something though. |
git@github.com:flutter/engine.git/compare/5051bef17bdc...e609577 git log 5051bef..e609577 --no-merges --oneline 2019-10-30 mklim@google.com Revert "Turn on RasterCache based on view hierarchy (flutter#13360)" (flutter/engine#13442) 2019-10-30 mklim@google.com Turn on RasterCache based on view hierarchy (flutter/engine#13360) 2019-10-30 bkonyi@google.com Roll src/third_party/dart d3a5b82355..f30b494035 (9 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC cbracken@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
This caused EmbedderTest.VerifyB143464703 to fail after merging into
master.
This reverts commit 3ad3bc7.
Opens flutter/flutter#38903.