-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flutter_runner] fix a11y tests #13947
Conversation
Instead of running over 400000000 nodes, do something a little quicker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - the point of this test is to ensure that a large update is split into multiple FIDL messages, which is still happening even with the smaller values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The point of this test was to make sure we could break up fidl messages but also to make sure we could handle the boundary conditions. Now we're not testing that anymore. Why was this done? |
The The test was timing out when handling a tree with 20000*20000 nodes. |
Ahhh ok. That makes sense. LGTM. |
git@github.com:flutter/engine.git/compare/176f56329631...6bf311f git log 176f563..6bf311f --no-merges --oneline 2019-11-20 bkonyi@google.com Roll src/third_party/dart b188632458..867a6e0e52 (4 commits) (flutter/engine#13948) 2019-11-20 gw280@google.com Ensure we use the base CompositorContext's AcquireFrame method when screenshotting (flutter/engine#13934) 2019-11-20 chinmaygarde@google.com Update SwiftShader to 5d1e854. (flutter/engine#13945) 2019-11-20 ianloic@google.com [flutter_runner] fix a11y tests (flutter/engine#13947) 2019-11-20 bkonyi@google.com Roll src/third_party/dart 8342ec2c71..b188632458 (2 commits) (flutter/engine#13942) 2019-11-20 ferhat@gmail.com Fix edge detection for correct dom_renderer reset (flutter/engine#13940) 2019-11-20 bkonyi@google.com Roll src/third_party/dart 1f933abcee..8342ec2c71 (12 commits) (flutter/engine#13941) 2019-11-20 50856934+nturgut@users.noreply.github.com [web] Flutter for web autocorrect support (flutter/engine#13922) 2019-11-20 skia-flutter-autoroll@skia.org Roll src/third_party/skia e678b79c489d..935a35d972e5 (13 commits) (flutter/engine#13927) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Instead of running over 400000000 nodes, do something a little quicker.