[fuchsia] Ensure we do not initialize nan RoundedRectangles #13971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskakaushik
force-pushed
the
temporarily-unblock-fuchsia
branch
from
da83110
to
f248484
Compare
Also initializes physical shape layer vars to empty.
iskakaushik
force-pushed
the
temporarily-unblock-fuchsia
branch
from
f248484
to
b002bc9
Compare
jason-simmons
approved these changes
Nov 22, 2019
| @@ -71,6 +71,13 @@ void SceneUpdateContext::CreateFrame(scenic::EntityNode entity_node, | |||
| if (rrect.isEmpty()) | |||
| return; | |||
|
|
|||
| // isEmpty should account for this, but we are adding these experimental | |||
| // checks to validate if this is the root cause for b/144933519. | |||
| if (std::isnan(rrect.width()) || std::isnan(rrect.height())) { | |||
There was a problem hiding this comment.
rrect.rect().isFinite() ought to do the same thing. Also, shouldn't this check happen before setting the clip planes? Might be a worthwhile check either way as this input comes from the framework and there doesn't seem to be any validation on the results of the rrect as it is constructed from a canvas path. Maybe the path wasn't closed or was reset before being given to the engine. Not sure.
There was a problem hiding this comment.
rrect.isEmpty should already account for this. Our suspicion is that is might not be the working as intended on some devices. I added some additional logs to be 100% sure that this is not the case. I am continuing to investigate the above issue.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 22, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 22, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also initializes physical shape layer vars to empty.