A11y desktop fix the method call #14056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nturgut
added
platform-web
yjbanov
approved these changes
Nov 27, 2019
|
But also, in a follow-up PR, let's write a test for it. |
Yes, we should thanks :) |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 27, 2019
skia-flutter-autoroll
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 28, 2019
* f61bec8 Pass "null" when copy data is null to iOS pasteboard.string (flutter/engine#14046) * 268107d fixing the method call for testing semantics (flutter/engine#14056) * 35937eb Roll src/third_party/dart 134e0e28cd..96e7a4ff30 (38 commits) (flutter/engine#14058)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrong method was getting called, so it was bypassing the check to see if semantics were already enabled. If semantics is enabled the placeholder is null. This was the cause of null errors.
Fixing: flutter/flutter#45709