New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise API level for reportFullyDrawn #14146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thanks dan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dnfield , can we consider that the fix you just made was taken into account by the latest version of flutter poster on its reference site. just want to know or we have to make the fix ourself.
my app crash on kitkat version after updating my flutter sdk to "1.12.13" and i have to apply your patch to fix the bug crash app ERROR:flutter/shell/platform/android/platform_view_android_jni.cc(39)] java.lang.SecurityException: uid 10062 does not have android.permission.UPDATE_DEVICE_STATS. |
This is not available on stable yet. It is being considered for a hotfix but I have no ETA on that right now. |
Fixes flutter/flutter#46172
I'm not sure how we could really test this, short of adding API 19 specifically to the devicelab.