Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise API level for reportFullyDrawn #14146

Merged
merged 1 commit into from Dec 5, 2019
Merged

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Dec 5, 2019

Fixes flutter/flutter#46172

I'm not sure how we could really test this, short of adding API 19 specifically to the devicelab.

Copy link
Contributor

@matthew-carroll matthew-carroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@liyuqian liyuqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xster
Copy link
Member

xster commented Dec 5, 2019

thanks dan

@dnfield dnfield merged commit 2a1ade7 into flutter:master Dec 5, 2019
@dnfield dnfield deleted the api_check branch December 5, 2019 22:51
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 6, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 6, 2019
Copy link

@nicodoss nicodoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dnfield , can we consider that the fix you just made was taken into account by the latest version of flutter poster on its reference site. just want to know or we have to make the fix ourself.

@nicodoss
Copy link

my app crash on kitkat version after updating my flutter sdk to "1.12.13" and i have to apply your patch to fix the bug crash app ERROR:flutter/shell/platform/android/platform_view_android_jni.cc(39)] java.lang.SecurityException: uid 10062 does not have android.permission.UPDATE_DEVICE_STATS.
E/flutter (10954): at android.app.Activity.reportFullyDrawn(Activity.java:1548)

@dnfield
Copy link
Contributor Author

dnfield commented Dec 19, 2019

This is not available on stable yet. It is being considered for a hotfix but I have no ETA on that right now.

dnfield added a commit to dnfield/engine that referenced this pull request Jan 23, 2020
filmil pushed a commit to filmil/engine that referenced this pull request Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants