Enable web engine unit tests on Firefox #14267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
reviewed
Dec 9, 2019
yjbanov
approved these changes
Dec 9, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 10, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Dec 10, 2019
flutter/engine@b9080c9...2805da9 git log b9080c9..2805da9 --first-parent --oneline 2019-12-10 50856934+nturgut@users.noreply.github.com Enable web engine unit tests on Firefox (flutter/engine#14267) 2019-12-09 cstout@google.com [shell][fuchsia] Add lib/async/default.h 2019-12-09 skia-flutter-autoroll@skia.org Roll src/third_party/skia c937bc50250d..095d2468a075 (7 commits) (flutter/engine#14269) 2019-12-09 hterkelsen@users.noreply.github.com Use the versioned canvaskit from unpkg. (flutter/engine#14264) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Mar 13, 2020
* Enable web engine unit tests on Firefox * addressing PR comments * addressing PR comments * fix the version name on the lock file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable web engine unit tests on Firefox
Fixes: flutter/flutter#44959
Issue for tracking the disabled tests: flutter/flutter#46638