Support timeline can be enabled in release mode #14521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuanhuihui
changed the title
|
Enable SUPPORT_TIMELINE macro, capture systrace in release mode as below:
|
chinmaygarde
approved these changes
Dec 17, 2019
|
relation to flutter/flutter#47771 |
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timeline function needs ServiceIsolate to cooperate with it, so it will be controlled by the SUPPORT_TIMELINE macro and FLAG_support_service, but systrace does not require ServiceIsolate to work properly.
SUPPORT_TIMELINE macro should be used to determine whether to enable systrace in release mode. For android, systrace is supported in release mode by default. When using a hybrid project of android native and flutter, we can control the SUPPORT_TIMELINE macro through a script to decide whether to enable systrace in release mode, which is used to assist in analyzing performance issues in production.
endless_trace_buffer, trace_startup, trace_skia, trace_systrace, these trace-related parameter assignments should be put together to initialize more clearly. By default, SUPPORT_TIMELINE is turned off, so it will not affect the current logic.
I have submitted PRs to better support systrace，as below: