Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlutterOverlayView cannot be released, causing IOSurface leaking. #15147

Closed
wants to merge 2 commits into from
Closed

FlutterOverlayView cannot be released, causing IOSurface leaking. #15147

wants to merge 2 commits into from

Conversation

linyu92
Copy link

@linyu92 linyu92 commented Jan 4, 2020

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@auto-assign auto-assign bot requested a review from flar January 4, 2020 14:41
@linyu92
Copy link
Author

linyu92 commented Jan 4, 2020

I signed it! @googlebot

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@linyu92
Copy link
Author

linyu92 commented Jan 4, 2020

@googlebot I fixed it.

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

There were a few other leak-related PRs similar to this one; I haven't verified how much overlap if any there is, but this is a correct fix -- thanks!

@shorben07
Copy link

These leaks already fixed in master #14326

@linyu92
Copy link
Author

linyu92 commented Jan 10, 2020

OK,waiting for new v1.12.13-hotfixes.

@@ -478,7 +478,7 @@ - (instancetype)initWithSemanticsObject:(SemanticsObject*)object {
if (controller) {
_platformView = [controller->GetPlatformViewByID(object.node.platformViewId) view];
}
self.accessibilityElements = @[ _semanticsObject, _platformView ];
// self.accessibilityElements = @[ _semanticsObject, _platformView ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take a second pass at this PR, but if this code turns out to be unnecessary, we'll want to delete this line, as we don't check in commented out code.

@chinmaygarde
Copy link
Member

This has already been applied. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants