[fuchsia] Add a diagnostics directory to the set of remote dirs (#14566) #15258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iskakaushik not sure what I did in #15094, got closed and had to re-open again. PTAL |
gaaclarke
approved these changes
Jan 9, 2020
…ry exists This reverts commit 4312d37. Once https://fuchsia-review.googlesource.com/c/topaz/+/351729 lands, the diagnostics directory will be present, this would be safe to do and the roller won't be blocked again.
|
Landing on red (more like purple). The only thing that is broke right now is Fuchsia tests which is flakey. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
…sure entry exists (flutter/engine#15258)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
…sure entry exists (flutter/engine#15258)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
…sure entry exists (flutter/engine#15258)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
…sure entry exists (flutter/engine#15258)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
…sure entry exists (flutter/engine#15258)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
…sure entry exists (flutter/engine#15258)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
…sure entry exists (flutter/engine#15258)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2020
…sure entry exists (flutter/engine#15258)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 11, 2020
…sure entry exists (flutter/engine#15258)
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
…ry exists (flutter#15258) This reverts commit 4312d37. Once https://fuchsia-review.googlesource.com/c/topaz/+/351729 lands, the diagnostics directory will be present, this would be safe to do and the roller won't be blocked again.
NoamDev
added a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
…sure entry exists (flutter#15258)" This reverts commit 1c3dcf6.
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Mar 13, 2020
…ry exists (flutter#15258) This reverts commit 4312d37. Once https://fuchsia-review.googlesource.com/c/topaz/+/351729 lands, the diagnostics directory will be present, this would be safe to do and the roller won't be blocked again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 4312d37.
https://fuchsia-review.googlesource.com/c/topaz/+/351729 has landed adding the out/diagnostics dir to all dart components.