[web] Freeze window.defaultRouteName #15565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flar
reviewed
Jan 14, 2020
| @override | ||
| String get defaultRouteName => _browserHistory.currentPath; | ||
| String get defaultRouteName => _defaultRouteName ??= _browserHistory.currentPath; |
There was a problem hiding this comment.
Should it be frozen on construction, or when the browser window opens rather than on first access?
There was a problem hiding this comment.
We want to delay the initialization of defaultRouteName a bit so that the app has time to initialize the engine and set locationStrategy which is used by _browserHistory to get the current path.
But once the app gets the value of the default route name, it shouldn't change after that.
yjbanov
approved these changes
Jan 14, 2020
| @@ -99,8 +99,10 @@ class EngineWindow extends ui.Window { | |||
| /// Simulates clicking the browser's back button. | |||
| Future<void> webOnlyBack() => _browserHistory.back(); | |||
|
|
|||
| String _defaultRouteName; | |||
There was a problem hiding this comment.
It took me a while to realize (found the ??= in the code) that this is lazy-initialized and cached route name. I think a comment would be useful.
mdebbar
added
the
waiting for tree to go green
nturgut
approved these changes
Jan 15, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 16, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jan 16, 2020
flutter/engine@be20fb6...09d892b git log be20fb6..09d892b --first-parent --oneline 2020-01-15 mouad.debbar@gmail.com [web] Freeze window.defaultRouteName (flutter/engine#15565) 2020-01-15 hterkelsen@users.noreply.github.com Upgrade to CanvasKit 0.11 (flutter/engine#15677) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
NoamDev
added a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
This reverts commit 943f3cd.
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with some routing-related issues in Flutter Gallery's Shrine and other apps (flutter/flutter#43982 (comment)).