Fix delete of entire selection in macOS text input #16276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where deleteBackward was checking for being at the start of the text before checking for a non-empty selection, breaking deletion when the entire text field was selected. Also removes an (incorrect) post-deletion position update that was redundant with code in insertText:replacementRange:, and thus having no effect. Fixes flutter/flutter#46150
franciscojma86
approved these changes
Jan 31, 2020
stuartmorgan
added
the
waiting for tree to go green
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
stuartmorgan
added
the
waiting for tree to go green
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
stuartmorgan
added
the
waiting for tree to go green
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
|
Landing manually, since I keep getting different infa flake each time. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 4, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 4, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 4, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 4, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Feb 4, 2020
flutter/engine@810b9b9...44f24bd git log 810b9b9..44f24bd --first-parent --oneline 2020-02-03 stuartmorgan@google.com Fix delete of entire selection in macOS text input (flutter/engine#16276) 2020-02-03 mouad.debbar@gmail.com [web][felt] If full dart-sdk isn't available, install it (flutter/engine#16341) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC cbracken@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
Fixes a bug where deleteBackward was checking for being at the start of the text before checking for a non-empty selection, breaking deletion when the entire text field was selected. Also removes an (incorrect) post-deletion position update that was redundant with code in insertText:replacementRange:, and thus having no effect. Fixes flutter/flutter#46150
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where deleteBackward was checking for being at the start of
the text before checking for a non-empty selection, breaking deletion
when the entire text field was selected.
Also removes an (incorrect) post-deletion position update that was
redundant with code in insertText:replacementRange:, and thus having no
effect.
Fixes flutter/flutter#46150
(In practice flutter/flutter#46150 was
already fixed by flutter/flutter#49760, but until we
resolve the fact that we have two different code paths handling some
text model updates, we should keep the embedding version correct since
we may well make it authoritative in the future.)