-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unused import in Android embedder #16494
Conversation
android.os.Parcelable was added in commit 6d5aaa0 but never used.
Quick cleanup based on an internal roll this morning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Technically all PRs need tests but there is definitely no way to test for this. I think having our existing JUnit test suite build and pass with this PR is enough.
Unused import cleanups are technically tested by the compiler itself -- no manual testing required. 😉 |
I think the real takeaway here is we should add unused imports linting to our presubmits. Filed flutter/flutter#50353. |
* c932214 Ensure fields of Rect and OffsetBase classes are optimized as non-null. (flutter/engine#16465) * 5c70356 Simplify task queues locking mechanism (flutter/engine#16477) * d589dde Fix text range logic for a11y (flutter/engine#16496) * 1a4f4e3 Fix unused import in Android embedder (flutter/engine#16494) * 964ae10 Disable ShellTest.WaitForFirstFrameTimeout on Fuchsia (flutter/engine#16495) * 6158f03 Roll src/third_party/skia 87e3bef6f82f..9f3eef796f63 (7 commits) (flutter/engine#16493)
android.os.Parcelable was added in commit 6d5aaa0 but never used.
This reverts commit f539320.
android.os.Parcelable was added in commit
6d5aaa0 but never used.