Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update hash code logic on the web #16624

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Conversation

yjbanov
Copy link
Contributor

@yjbanov yjbanov commented Feb 14, 2020

Copy lib/ui/hash_codes.dart to lib/web_ui/lib/src/ui/hash_codes.dart and write a test checking that the implementation behaves correctly on the Web.

Fixes flutter/flutter#50651

@yjbanov yjbanov added the Work in progress (WIP) Not ready (yet) for review! label Feb 14, 2020
@yjbanov
Copy link
Contributor Author

yjbanov commented Feb 18, 2020

Landing on red. Fuchsia infra is flaky.

@yjbanov yjbanov merged commit 48d64c1 into flutter:master Feb 18, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 19, 2020
iskakaushik pushed a commit to flutter/flutter that referenced this pull request Feb 20, 2020
* 48d64c1 update hash code logic on the web (flutter/engine#16624)

* 110c1c9 Lift restriction that embedders may not trample the render thread OpenGL context in composition callbacks. (flutter/engine#16653)

* ca6165f Roll src/third_party/skia c1bb9cba16be..7281a8623799 (9 commits) (flutter/engine#16665)

* c264e1c Roll src/third_party/dart 999eeea5a3ff..3883c6070942 (5 commits) (flutter/engine#16666)

* 1cd1304 Control test timeouts based on debugger status or command line flags. (flutter/engine#16375)

* 9309ff5 Roll src/third_party/skia 7281a8623799..fe6fe6c5a8a8 (7 commits) (flutter/engine#16667)

* d03582d URL-encode asset URLs so assets are properly loaded (flutter/engine#16630)

* 40e3ab1 Roll fuchsia/sdk/core/mac-amd64 from 06MUz... to _jvYk... (flutter/engine#16668)

* ef9e7b1 Revert "Lift restriction that embedders may not trample the render thread OpenGL context in composition callbacks. (#16653)" (flutter/engine#16674)

* 16eeac5 Roll src/third_party/skia fe6fe6c5a8a8..799a23cf0602 (1 commits) (flutter/engine#16669)

* c796205 Roll fuchsia/sdk/core/linux-amd64 from 2W9Xr... to VHyDa... (flutter/engine#16670)

* 4f4a1d5 Roll src/third_party/dart 3883c6070942..c11c0ae3fdca (9 commits) (flutter/engine#16673)

* 80f73ee Roll src/third_party/skia 799a23cf0602..d0d033a12556 (3 commits) (flutter/engine#16675)

* 151688c Roll src/third_party/skia d0d033a12556..a037445e07a7 (4 commits) (flutter/engine#16676)

* 8e82311 Roll src/third_party/skia a037445e07a7..c5ff41f2976e (1 commits) (flutter/engine#16677)

* 84dc383 Roll src/third_party/dart c11c0ae3fdca..707ecda05e14 (1 commits) (flutter/engine#16678)
NoamDev pushed a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
NoamDev added a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
@yjbanov yjbanov deleted the hash-codes branch June 22, 2021 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants