Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web] Fixes for Firefox & Safari double underline decoration bugs. #16994

Merged
merged 8 commits into from
Mar 10, 2020
Merged

[web] Fixes for Firefox & Safari double underline decoration bugs. #16994

merged 8 commits into from
Mar 10, 2020

Conversation

ferhatb
Copy link
Contributor

@ferhatb ferhatb commented Mar 6, 2020 •
edited by mdebbar
Loading

@ferhatb ferhatb requested a review from mdebbar March 6, 2020 21:07
mdebbar
mdebbar approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR also fixes flutter/flutter#49946.

@ferhatb ferhatb merged commit a3e883b into flutter:master Mar 10, 2020
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2020
@engine-flutter-autoroll
a3e883b [web] Fixes for Firefox & Safari double underline decoration …
5d5577c 
…bugs. (flutter/engine#16994)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2020
@engine-flutter-autoroll
a3e883b [web] Fixes for Firefox & Safari double underline decoration …
4a724de 
…bugs. (flutter/engine#16994)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2020
@engine-flutter-autoroll
a3e883b [web] Fixes for Firefox & Safari double underline decoration …
9032da3 
…bugs. (flutter/engine#16994)
This was referenced Mar 10, 2020
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2020
@engine-flutter-autoroll
a3e883b [web] Fixes for Firefox & Safari double underline decoration …
1ca203a 
…bugs. (flutter/engine#16994)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
a3e883b [web] Fixes for Firefox & Safari double underline decoration …
bd5a0ff 
…bugs. (flutter/engine#16994)
This was referenced Mar 11, 2020
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
a3e883b [web] Fixes for Firefox & Safari double underline decoration …
fe83603 
…bugs. (flutter/engine#16994)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
a3e883b [web] Fixes for Firefox & Safari double underline decoration …
ec3d15e 
…bugs. (flutter/engine#16994)
This was referenced Mar 11, 2020
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
a3e883b [web] Fixes for Firefox & Safari double underline decoration …
5507976 
…bugs. (flutter/engine#16994)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
a3e883b [web] Fixes for Firefox & Safari double underline decoration …
6cb7c0e 
…bugs. (flutter/engine#16994)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
a3e883b [web] Fixes for Firefox & Safari double underline decoration …
5dcff87 
…bugs. (flutter/engine#16994)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
a3e883b [web] Fixes for Firefox & Safari double underline decoration …
0c2b8b9 
…bugs. (flutter/engine#16994)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
a3e883b [web] Fixes for Firefox & Safari double underline decoration …
480bdb7 
…bugs. (flutter/engine#16994)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
a3e883b [web] Fixes for Firefox & Safari double underline decoration …
9ac9e32 
…bugs. (flutter/engine#16994)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
a3e883b [web] Fixes for Firefox & Safari double underline decoration …
5015416 
…bugs. (flutter/engine#16994)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2020
Closed
jason-simmons added a commit to jason-simmons/flutter that referenced this pull request Mar 11, 2020
@jason-simmons
Manual roll engine 0e2c8fe..6d8611d (31 commits)
449aea9 
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/dart 4093d08271f6..37530145ff53 (4 commits) (flutter/engine#17090)
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia bf355123ae3b..0340292972b9 (9 commits) (flutter/engine#17089)
2020-03-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from r_oCI... to 0Z8VF... (flutter/engine#17087)
2020-03-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from v32mJ... to X3Xm2... (flutter/engine#17086)
2020-03-11 chinmaygarde@gmail.com Remove the unused method on iOS surface to make the resource context current. (flutter/engine#17084)
2020-03-11 chinmaygarde@gmail.com Revert "Add support for the Metal backend on all iOS builds. (flutter#17080)" (flutter/engine#17088)
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/dart ace1d9b9213a..4093d08271f6 (12 commits) (flutter/engine#17082)
2020-03-11 chinmaygarde@google.com Add support for the Metal backend on all iOS builds. (flutter/engine#17080)
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia d3f67dbf9f36..bf355123ae3b (9 commits) (flutter/engine#17079)
2020-03-11 chinmaygarde@google.com Disable Embedder11yTest::A11yTreeIsConsistent to unblock LUCI. (flutter/engine#17081)
2020-03-10 chinmaygarde@google.com Gather demangled stack traces and report the same to console on crashes. (flutter/engine#16450)
2020-03-10 chinmaygarde@google.com Implement asynchronous texture uploads when using the Metal backend on iOS. (flutter/engine#17046)
2020-03-10 skia-flutter-autoroll@skia.org Roll src/third_party/dart 97674262bc29..ace1d9b9213a (14 commits) (flutter/engine#17078)
2020-03-10 egarciad@google.com Add RTree to flow (flutter/engine#16923)
2020-03-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 78dac6dcb222..d3f67dbf9f36 (6 commits) (flutter/engine#17072)
2020-03-10 flar@google.com Revert "Fix bounds of image_filter_layer (flutter#16960)" (flutter/engine#17074)
2020-03-10 chinmaygarde@google.com Use the ELF loader to setup AOT symbols in benchmark runner. (flutter/engine#17051)
2020-03-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 23899c64e3db..78dac6dcb222 (19 commits) (flutter/engine#17069)
2020-03-10 aam@google.com Roll dart to 97674262bc29447dc59d5c93024b18b27d4bcf98. (flutter/engine#17067)
2020-03-10 ferhat@gmail.com [web] Fixes for Firefox & Safari double underline decoration bugs. (flutter/engine#16994)
2020-03-10 dnfield@google.com Avoid capturing this unsafely in MultiFrameCodec (flutter/engine#16824)
2020-03-10 yjbanov@google.com Revert "Revert "fix shadows and mask filter blurs (flutter#16963)" (flutter#17008)" (flutter/engine#17040)
2020-03-10 ferhat@gmail.com Add support for firefox mac installer. Update web_ui pubspec for http.wq (flutter/engine#17044)
2020-03-09 yjbanov@google.com fix "TREE INCONSISTENT" noise in compositing_test.dart (flutter/engine#16995)
2020-03-09 yjbanov@google.com Add more child lifecycle tests (flutter/engine#16689)
2020-03-09 chris@bracken.jp Add libfreetype6-dev to desktop Linux dependencies (flutter/engine#17020)
2020-03-09 liyuqian@google.com Disable shell benchmarks (flutter/engine#17038)
2020-03-09 flar@google.com Fix bounds of image_filter_layer (flutter/engine#16960)
2020-03-09 liyuqian@google.com Record fml and shell benchmarks (flutter/engine#16991)
2020-03-09 skia-flutter-autoroll@skia.org Roll src/third_party/skia c56950442dd1..23899c64e3db (11 commits) (flutter/engine#17033)
2020-03-09 yjbanov@google.com use commit date instead of author date (flutter/engine#17032)
@jason-simmons jason-simmons mentioned this pull request Mar 11, 2020
Merged
13 tasks
jason-simmons added a commit to flutter/flutter that referenced this pull request Mar 11, 2020
@jason-simmons
Manual roll engine 0e2c8fe..6d8611d (31 commits) (#52431)
5e74b00 
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/dart 4093d08271f6..37530145ff53 (4 commits) (flutter/engine#17090)
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia bf355123ae3b..0340292972b9 (9 commits) (flutter/engine#17089)
2020-03-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from r_oCI... to 0Z8VF... (flutter/engine#17087)
2020-03-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from v32mJ... to X3Xm2... (flutter/engine#17086)
2020-03-11 chinmaygarde@gmail.com Remove the unused method on iOS surface to make the resource context current. (flutter/engine#17084)
2020-03-11 chinmaygarde@gmail.com Revert "Add support for the Metal backend on all iOS builds. (#17080)" (flutter/engine#17088)
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/dart ace1d9b9213a..4093d08271f6 (12 commits) (flutter/engine#17082)
2020-03-11 chinmaygarde@google.com Add support for the Metal backend on all iOS builds. (flutter/engine#17080)
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia d3f67dbf9f36..bf355123ae3b (9 commits) (flutter/engine#17079)
2020-03-11 chinmaygarde@google.com Disable Embedder11yTest::A11yTreeIsConsistent to unblock LUCI. (flutter/engine#17081)
2020-03-10 chinmaygarde@google.com Gather demangled stack traces and report the same to console on crashes. (flutter/engine#16450)
2020-03-10 chinmaygarde@google.com Implement asynchronous texture uploads when using the Metal backend on iOS. (flutter/engine#17046)
2020-03-10 skia-flutter-autoroll@skia.org Roll src/third_party/dart 97674262bc29..ace1d9b9213a (14 commits) (flutter/engine#17078)
2020-03-10 egarciad@google.com Add RTree to flow (flutter/engine#16923)
2020-03-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 78dac6dcb222..d3f67dbf9f36 (6 commits) (flutter/engine#17072)
2020-03-10 flar@google.com Revert "Fix bounds of image_filter_layer (#16960)" (flutter/engine#17074)
2020-03-10 chinmaygarde@google.com Use the ELF loader to setup AOT symbols in benchmark runner. (flutter/engine#17051)
2020-03-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 23899c64e3db..78dac6dcb222 (19 commits) (flutter/engine#17069)
2020-03-10 aam@google.com Roll dart to 97674262bc29447dc59d5c93024b18b27d4bcf98. (flutter/engine#17067)
2020-03-10 ferhat@gmail.com [web] Fixes for Firefox & Safari double underline decoration bugs. (flutter/engine#16994)
2020-03-10 dnfield@google.com Avoid capturing this unsafely in MultiFrameCodec (flutter/engine#16824)
2020-03-10 yjbanov@google.com Revert "Revert "fix shadows and mask filter blurs (#16963)" (#17008)" (flutter/engine#17040)
2020-03-10 ferhat@gmail.com Add support for firefox mac installer. Update web_ui pubspec for http.wq (flutter/engine#17044)
2020-03-09 yjbanov@google.com fix "TREE INCONSISTENT" noise in compositing_test.dart (flutter/engine#16995)
2020-03-09 yjbanov@google.com Add more child lifecycle tests (flutter/engine#16689)
2020-03-09 chris@bracken.jp Add libfreetype6-dev to desktop Linux dependencies (flutter/engine#17020)
2020-03-09 liyuqian@google.com Disable shell benchmarks (flutter/engine#17038)
2020-03-09 flar@google.com Fix bounds of image_filter_layer (flutter/engine#16960)
2020-03-09 liyuqian@google.com Record fml and shell benchmarks (flutter/engine#16991)
2020-03-09 skia-flutter-autoroll@skia.org Roll src/third_party/skia c56950442dd1..23899c64e3db (11 commits) (flutter/engine#17033)
2020-03-09 yjbanov@google.com use commit date instead of author date (flutter/engine#17032)
@tsinis
Copy link

tsinis commented Apr 5, 2020

This PR also fixes flutter/flutter#49946.

Cannot confirm, i see this issue on custom fonts on Firefox...

@jmshrv jmshrv mentioned this pull request Jul 16, 2020
Closed
@ferhatb ferhatb deleted the double_underline branch February 11, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdebbar mdebbar mdebbar approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
4 participants
@ferhatb @tsinis @mdebbar @googlebot