Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Implement unobstructed Platform Views on iOS" #17233

Merged
merged 1 commit into from
Mar 20, 2020
Merged

Revert "Implement unobstructed Platform Views on iOS" #17233

merged 1 commit into from
Mar 20, 2020

Conversation

blasten
Copy link

@blasten blasten commented Mar 20, 2020 •
edited
Loading

Broke some of the scenario tests:

ScenariosUITests:
		-[PlatformViewMutationTransformTests testPlatformView]
		-[PlatformViewMutationClipPathTests testPlatformView]
		-[UnobstructedPlatformViewTests testOneOverlayPartialIntersection]
		-[UnobstructedPlatformViewTests testMultiplePlatformViewsWithoutOverlays]
		-[UnobstructedPlatformViewTests testPlatformViewsMaxOverlays]
		-[UnobstructedPlatformViewTests testOneOverlay]
		-[UnobstructedPlatformViewTests testMultiplePlatformViewsWithOverlays]
		-[UnobstructedPlatformViewTests testNoOverlay]
		-[UnobstructedPlatformViewTests testOneOverlayAndTwoIntersectingOverlays]
		-[UnobstructedPlatformViewTests testTwoIntersectingOverlays]

Reverts #17049

@blasten blasten requested a review from cyanglaz March 20, 2020 20:49
@auto-assign auto-assign bot requested a review from chinmaygarde March 20, 2020 20:49
@cyanglaz
Copy link
Contributor

LGTM

@blasten blasten merged commit 70f6d18 into master Mar 20, 2020
@blasten blasten deleted the revert-17049-unobstructed_pv branch March 20, 2020 21:46
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 20, 2020
@engine-flutter-autoroll
70f6d18 Revert "Implement unobstructed Platform Views on iOS (flutter…
4baac54 
…#17049)" (flutter/engine#17233)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 20, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 24, 2020
@engine-flutter-autoroll
70f6d18 Revert "Implement unobstructed Platform Views on iOS (flutter…
1f4a4b1 
…#17049)" (flutter/engine#17233)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 24, 2020
@engine-flutter-autoroll
70f6d18 Revert "Implement unobstructed Platform Views on iOS (flutter…
c17ea27 
…#17049)" (flutter/engine#17233)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 25, 2020
@engine-flutter-autoroll
70f6d18 Revert "Implement unobstructed Platform Views on iOS (flutter…
654a3fe 
…#17049)" (flutter/engine#17233)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
3 participants
@blasten @cyanglaz @googlebot