[web] Fix HtmlImage state pollution due to image.clone optimization #17370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
approved these changes
Mar 27, 2020
| builder2.pushClipRect( | ||
| const Rect.fromLTRB(0, 0, 100, 100), | ||
| ); | ||
| _drawTestPicture(builder2, 20, false); |
There was a problem hiding this comment.
This passes a smaller targetSize while claiming that the picture will be growing. Am I missing something?
There was a problem hiding this comment.
Added comment. Drawing the picture at actual size triggers new code path that reproduces the bug.
| builder2.pop(); | ||
|
|
||
| elm1.remove(); | ||
| html.document.body.append(builder2.build().webOnlyRootElement); |
There was a problem hiding this comment.
This test should also verify that the element was reused. Otherwise, if the canvas does not reuse the image element it will "fix the bug" by virtue of creating a new element instead of reusing.
There was a problem hiding this comment.
We are reusing the ImageElement, not the canvas. I noticed we don't have such a test for canvas reuse, added one as part of #17378.
| builder2.pop(); | ||
|
|
||
| elm1.remove(); | ||
| html.document.body.append(builder2.build().webOnlyRootElement); |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 31, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 31, 2020
goderbauer
pushed a commit
to goderbauer/engine
that referenced
this pull request
Apr 16, 2020
…lutter#17370) * fix drawImage style when destination width==source * Add regression test * dartfmt * update golden lock * Addressed review comment * remove transform reset since _drawImage is called
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue flutter/flutter#52490. That issue, second sample reproduces this bug.
Golden test added to reproduce painting with same instance using dst < src rect and then dst = src rect.
Screenshot after fix:
