Reland "add limited analysis options (#17332)" #17374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This time I'm starting without Cirrus. Will add Cirrus serpartely from code changes. This reverts commit 6d33ee1.
ferhatb
approved these changes
Mar 27, 2020
mdebbar
approved these changes
Mar 27, 2020
|
fyi some CI tasks are failing without this PR: https://github.com/flutter/engine/runs/537931841. We were going to land #17375 but we'll give preference to this. |
The analyzer change was reverted. This is the second attempt to land it. The |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This time the code changes go in without the Cirrus check. I'll submit the Cirrus check separately so that there are few code changes in between, reducing the risk of a linter warning creeping in.