Enable Vulkan validation layers for shell_test #17684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vulkan/vulkan_utilities.cc
Outdated
| @@ -10,16 +10,24 @@ | |||
|
|
|||
| namespace vulkan { | |||
|
|
|||
| static bool sValidationLayersEnabled = false; | |||
There was a problem hiding this comment.
Let's stay away from static variables. This makes it hard to perform validation on a per Flutter application level basis. This flag can be store in VulkanApplication instead and queried when the layers are being setup.
gw280
force-pushed
the
gwright-enable-validation
branch
from
6d9909d
to
92307ea
Compare
Done |
chinmaygarde
approved these changes
Apr 17, 2020
gw280
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% clear on what the implied relationship between IsDebuggingEnabled() and ValidationLayersEnabled() should be here, but I've made validation layers strictly imply that debugging is enabled.