Bundle the validation layers and enable them if --enable-vulkan-validation-layers is specified to gn #17854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Apr 21, 2020
gw280
added
the
waiting for tree to go green
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
--enable-vulkan-validation-layers is specified to gn
gw280
force-pushed
the
gwright-runner-validation
branch
3 times, most recently
from
7217fc0
to
1c124a2
Compare
gw280
force-pushed
the
gwright-runner-validation
branch
from
1c124a2
to
9573761
Compare
|
So after discussing this with @mehmetf this is the new approach here. The plan is to always attempt to load the validation layers on Fuchsia, and if we need a validation-enabled build we just repackage the existing far with the validation layers included. This can be done using the Fuchsia SDK and removes the need to roll additional fars around. |
chinmaygarde
approved these changes
Apr 30, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2020
…an-validation-layers is specified to gn (flutter/engine#17854)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2020
…an-validation-layers is specified to gn (flutter/engine#17854)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2020
…an-validation-layers is specified to gn (flutter/engine#17854)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2020
…an-validation-layers is specified to gn (flutter/engine#17854)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2020
…an-validation-layers is specified to gn (flutter/engine#17854)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2020
…an-validation-layers is specified to gn (flutter/engine#17854)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2020
…an-validation-layers is specified to gn (flutter/engine#17854)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2020
…an-validation-layers is specified to gn (flutter/engine#17854)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2020
…an-validation-layers is specified to gn (flutter/engine#17854)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 2, 2020
…an-validation-layers is specified to gn (flutter/engine#17854)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 5, 2020
…an-validation-layers is specified to gn (flutter/engine#17854)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The route I'm taking here is to always enable validation layers on Fuchsia if the gn flag is set. This is because having a settings flag is a) problematic regarding components (although my understanding here is very limited), and b) the validation layers .so is 6.5MB in size, so really we don't want to ship them in normal configurations anyway, which makes for much less of a compelling reason to add the complexity of having a runtime argument to enable them.