Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable safari font loading unit test #18232

Merged
merged 1 commit into from May 8, 2020
Merged

disable safari font loading unit test #18232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 12 additions & 4 deletions lib/web_ui/test/text/font_loading_test.dart
View file
Open in desktop
Expand Up @@ -26,8 +26,10 @@ Future<void> main() async {
ui.loadFontFromList(Uint8List(0), fontFamily: 'test-font'),
throwsA(TypeMatcher<Exception>()));
},
// TODO(nurhan): https://github.com/flutter/flutter/issues/56702
// TODO(nurhan): https://github.com/flutter/flutter/issues/50770
skip: browserEngine == BrowserEngine.edge);
skip: (browserEngine == BrowserEngine.edge ||
browserEngine == BrowserEngine.webkit));

test('loads Blehm font from buffer', () async {
expect(_containsFontFamily('Blehm'), false);
Expand All @@ -40,8 +42,10 @@ Future<void> main() async {

expect(_containsFontFamily('Blehm'), true);
},
// TODO(nurhan): https://github.com/flutter/flutter/issues/56702
// TODO(nurhan): https://github.com/flutter/flutter/issues/50770
skip: browserEngine == BrowserEngine.edge);
skip: (browserEngine == BrowserEngine.edge ||
browserEngine == BrowserEngine.webkit));

test('loading font should clear measurement caches', () async {
final ui.ParagraphStyle style = ui.ParagraphStyle();
Expand All @@ -66,8 +70,10 @@ Future<void> main() async {
expect(_containsFontFamily('Blehm'), true);
expect(TextMeasurementService.rulerManager.rulers.length, 0);
},
// TODO(nurhan): https://github.com/flutter/flutter/issues/56702
// TODO(nurhan): https://github.com/flutter/flutter/issues/50770
skip: browserEngine == BrowserEngine.edge);
skip: (browserEngine == BrowserEngine.edge ||
browserEngine == BrowserEngine.webkit));

test('loading font should send font change message', () async {
final ui.PlatformMessageCallback oldHandler = ui.window.onPlatformMessage;
Expand All @@ -93,8 +99,10 @@ Future<void> main() async {
expect(actualName, 'flutter/system');
expect(message, '{"type":"fontsChange"}');
},
// TODO(nurhan): https://github.com/flutter/flutter/issues/56702
// TODO(nurhan): https://github.com/flutter/flutter/issues/50770
skip: browserEngine == BrowserEngine.edge);
skip: (browserEngine == BrowserEngine.edge ||
browserEngine == BrowserEngine.webkit));
});
}

Expand Down