Run IOS unit tests on LUCI #19141
Run IOS unit tests on LUCI #19141
Conversation
nturgut
requested review from
yjbanov,
mdebbar and
harryterkelsen
and removed request for
GaryQian and
jason-simmons
| /// is used for combining [shouldSkip] information with the `context`. | ||
| /// See: [_PointerEventContext] [_MouseEventContext] [_TouchEventContext]. | ||
| /// TODO: https://github.com/flutter/flutter/issues/60033 | ||
| class _BrowserUnitTestContext<T extends _BasicEventContext> { |
There was a problem hiding this comment.
I also considered using Tuple: https://pub.dev/packages/tuple
@mdebbar let me know if this looks good to you or should I changed to Tuple2.
There was a problem hiding this comment.
I think this is way more readable than Tuple2, because you can name and document the fields.
| @@ -3,6 +3,10 @@ | |||
| // found in the LICENSE file. | |||
|
|
|||
| // @dart = 2.6 | |||
| // This test failed on iOS Safari. | |||
| // TODO: https://github.com/flutter/flutter/issues/60040 | |||
| @TestOn('chrome || firefox') | |||
There was a problem hiding this comment.
We should still run it in desktop Safari. The issue seems to be limited to the iOS Simulator: https://bugs.webkit.org/show_bug.cgi?id=191064.
There was a problem hiding this comment.
Desktop safari is not running, there is a blocker on infra side.
Do you want to keep it for the local development?
There was a problem hiding this comment.
Yes, you are right. I tested it locally with Safari Desktop: All tests passed!.
I changed the test to only skip for iOS-Safari.
| /// is used for combining [shouldSkip] information with the `context`. | ||
| /// See: [_PointerEventContext] [_MouseEventContext] [_TouchEventContext]. | ||
| /// TODO: https://github.com/flutter/flutter/issues/60033 | ||
| class _BrowserUnitTestContext<T extends _BasicEventContext> { |
There was a problem hiding this comment.
I think this is way more readable than Tuple2, because you can name and document the fields.
* change the version of simulator. luci bots only has 13.0 * skip failing pointer binding tests * skip path_metrics (canvaskit) and a method from surface_test * fix analyzer errors * remove extra added touch event context test * removing left overs for screenshot debugging * apply reviewers suggestion for skipping tests
(1) change the version of simulator. luci bots only has 13.0
(2) skip failing tests
flutter/flutter#60040
flutter/flutter#60036
flutter/flutter#60033
Example run on infra: https://chromium-swarm.appspot.com/task?id=4cf78088e41b5310
Fixes: flutter/flutter#53690