Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move OnDisplayPlatformView JNI call #19258

Merged
merged 1 commit into from
Jun 24, 2020

Conversation

blasten
Copy link

@blasten blasten commented Jun 24, 2020

Description

This will facilitate determining the z order of the platform views and the overlay surface views.

Related Issues

flutter/flutter#60140
flutter/flutter#60150

Tests

I added the following tests: These cases are covered by the scenario app, but they don't run in presubmit because of flutter/flutter#55326

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@blasten
Copy link
Author

blasten commented Jun 24, 2020

Merging. "Scenario App Integration Tests" is a flake. "flutter_fuchsia_unittests" is red, but this change shouldn't affect that.

@blasten blasten merged commit 9075224 into flutter:master Jun 24, 2020
@blasten blasten deleted the move_display_platform_jni_call branch June 24, 2020 18:01
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 24, 2020
zhongwuzw pushed a commit to zhongwuzw/engine that referenced this pull request Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants