Android native locale resolution algorithm #19266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| Locale preferredLocale = localeList.get(index); | ||
| // Look for exact match. | ||
| for (Locale locale : supportedLocales) { | ||
| if (preferredLocale == locale) { |
There was a problem hiding this comment.
Is it safe to use == here instead of .equals?
| Locale preferredLocale = context.getResources().getConfiguration().locale; | ||
| // Look for exact match. | ||
| for (Locale locale : supportedLocales) { | ||
| if (preferredLocale == locale) { |
There was a problem hiding this comment.
Also applies to use of == here
jason-simmons
approved these changes
Jun 25, 2020
GaryQian
added
the
waiting for tree to go green
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
GaryQian
added
the
waiting for tree to go green
|
LUCI failure is probably a flake. Landing. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements Android's locale resolution algorithm as described in https://developer.android.com/guide/topics/resources/multilingual-support
Due to evolving API, there are 3 versions implemented:
This implementation attempts to exactly emulate what Android would have done given the same parameters.