Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resubmit frame when the surface is switched #19555

Merged
merged 4 commits into from Jul 7, 2020

Conversation

blasten
Copy link

@blasten blasten commented Jul 6, 2020

Description

Resubmit frame after surfaces are switched.

Related Issues

flutter/flutter#58291

Tests

I added the following tests: Unit test

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

Copy link
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blasten blasten marked this pull request as ready for review July 7, 2020 00:10
@blasten blasten added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jul 7, 2020
@auto-assign auto-assign bot requested a review from gw280 July 7, 2020 00:10
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux Host Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite build_and_test_linux_unopt_debug has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jul 7, 2020
@blasten blasten merged commit 5f8e91c into flutter:master Jul 7, 2020
@blasten blasten deleted the resubmit_frame branch July 7, 2020 04:55
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 7, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 7, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 7, 2020
justinmc pushed a commit to justinmc/engine that referenced this pull request Jul 7, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 7, 2020
a-siva added a commit to a-siva/flutter that referenced this pull request Jul 7, 2020
3fe5edf Roll Skia from cf5e35f72130 to b4d60f807dbd (5 revisions) (flutter/engine#19587)
b919945 include list_libraries.dart as a snapshot for fuchsia
(flutter/engine#19567)
de0932b Manual roll of Dart 06cb010247...69aba23371 (flutter/engine#19577)
35b5aa5 switch const finder to package_config (flutter/engine#19576)
07d5090 Roll Skia from 0c0d8dd6d637 to cf5e35f72130 (13 revisions) (flutter/engine#19573)
0541502 kick build (flutter/engine#19575)
a53782f Roll Skia from 6130d5079d55 to 0c0d8dd6d637 (3 revisions) (flutter/engine#19570)
d0d6a4c Refactor Win32FlutterWindow in preparation for UWP windowing implementation (flutter/engine#18878)
110a579 Track motion events for reuse post gesture disambiguation (flutter/engine#19484)
5f8e91c Resubmit frame when the surface is switched (flutter/engine#19555)
ab0abdd Roll Fuchsia Linux SDK from TvWbh... to 1oAHN...
(flutter/engine#19566)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants