Fix lint errors in vulkan directory. #19991
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
gspencergoog
changed the title
gspencergoog
changed the title
gspencergoog
force-pushed
the
fix_lint3
branch
4 times, most recently
from
dda4917
to
2d11b07
Compare
vulkan/vulkan_window.cc
Outdated
| // This is just to make lint happy: MakeVulkan isn't defined unless SK_VULKAN is | ||
| // defined, and lint doesn't define SK_VULKAN. | ||
| #ifdef SK_VULKAN |
There was a problem hiding this comment.
Can we just use NOLINT? I'd prefer that.
There was a problem hiding this comment.
So would I, but no, without those #ifdefs, it's not just a lint error, it's a syntax error, since MakeVulkan isn't defined at all if SK_VULKAN isn't.
|
OK, I reverted |
gspencergoog
force-pushed
the
fix_lint3
branch
2 times, most recently
from
f0165ec
to
fd6087e
Compare
|
The Fuchsia build failure was a flake in a test that is now disabled. Is this ready to land? |
|
@gspencergoog is OOO but my understanding is that this was ready. We can wait for him to come back. |
Description
This fixes lint errors in the vulkan directory. This might be a little more controversial, but the reason that the lints were failing here was because of an include path problem that I think I solved.
There's one heinous hack in here. It's totally safe, but see if you can spot it...