fix clipped and transformed content in HTML clip #20310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
changed the title
ferhatb
approved these changes
Aug 6, 2020
| @@ -23,7 +23,7 @@ void main() async { | |||
| // Commit a recording canvas to a bitmap, and compare with the expected | |||
| Future<void> _checkScreenshot(RecordingCanvas rc, String fileName, | |||
| {Rect region = const Rect.fromLTWH(0, 0, 500, 500), | |||
| double maxDiffRatePercent = 0.0}) async { | |||
| double maxDiffRatePercent = 0.0, bool write = false}) async { | |||
There was a problem hiding this comment.
It's been useful the last few times I added new screenshot tests, but I can remove it if adds noise.
| @@ -35,7 +35,7 @@ void main() async { | |||
| sceneElement.append(engineCanvas.rootElement); | |||
| html.document.body.append(sceneElement); | |||
| await matchGoldenFile('$fileName.png', | |||
| region: region, maxDiffRatePercent: maxDiffRatePercent); | |||
| region: region, maxDiffRatePercent: maxDiffRatePercent, write: write); | |||
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 8, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 8, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apply
transform-origin: 0 0 0to the clipping element. Otherwise, we get wrong transform on the clipped content.Related Issues
Fixes flutter/flutter#61691
Tests
I added the following tests:
Added a new test in
canvas_draw_image_golden_test.dart, which reproduces this issue.This change requires a new golden: flutter/goldens#103