Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the dummy rasterizer delegate now that flutter_runner is in tree, and cleanup ctor params #20486

Merged
merged 2 commits into from Aug 13, 2020
Merged

Remove the dummy rasterizer delegate now that flutter_runner is in tree, and cleanup ctor params #20486

merged 2 commits into from Aug 13, 2020

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Aug 13, 2020 •
edited

Cleans up some TODOs around this code:

  • Makes flutter_runner use the shell instead of a "dummy delegate" that was originally created when flutter_runner was in the fuchsia tree and this kind of work required lots of coordination.
  • Since we're passing the shell as a delegate anyway, update the delegate interface to include the shell methods we care about in the ctor (task_runners and gpu_sync_switch).
  • Update all tests/embedders.

Noticed this while working through how to make #19842 work for Fuchsia.

Since this is a compatible refactoring, I'm not adding any new tests - changes are covered by the updated tests.

@auto-assign auto-assign bot requested a review from liyuqian August 13, 2020 18:10
@dnfield dnfield added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Aug 13, 2020
@fluttergithubbot fluttergithubbot merged commit 6d44559 into flutter:master Aug 13, 2020
@dnfield dnfield deleted the remove_dummy branch August 13, 2020 22:49
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2020
@engine-flutter-autoroll
6d44559 Remove the dummy rasterizer delegate now that flutter_runner …
0b24578 
…is in tree, and cleanup ctor params (flutter/engine#20486)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2020
@engine-flutter-autoroll
6d44559 Remove the dummy rasterizer delegate now that flutter_runner …
a42585f 
…is in tree, and cleanup ctor params (flutter/engine#20486)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2020
@engine-flutter-autoroll
6d44559 Remove the dummy rasterizer delegate now that flutter_runner …
ba14fc5 
…is in tree, and cleanup ctor params (flutter/engine#20486)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2020
@engine-flutter-autoroll
6d44559 Remove the dummy rasterizer delegate now that flutter_runner …
d35d2c4 
…is in tree, and cleanup ctor params (flutter/engine#20486)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2020
@engine-flutter-autoroll
6d44559 Remove the dummy rasterizer delegate now that flutter_runner …
4f8d178 
…is in tree, and cleanup ctor params (flutter/engine#20486)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2020
@engine-flutter-autoroll
6d44559 Remove the dummy rasterizer delegate now that flutter_runner …
325cba9 
…is in tree, and cleanup ctor params (flutter/engine#20486)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2020
@engine-flutter-autoroll
6d44559 Remove the dummy rasterizer delegate now that flutter_runner …
c5f7c8d 
…is in tree, and cleanup ctor params (flutter/engine#20486)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2020
@engine-flutter-autoroll
6d44559 Remove the dummy rasterizer delegate now that flutter_runner …
9c9baf6 
…is in tree, and cleanup ctor params (flutter/engine#20486)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2020
@engine-flutter-autoroll
6d44559 Remove the dummy rasterizer delegate now that flutter_runner …
61c0895 
…is in tree, and cleanup ctor params (flutter/engine#20486)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2020
@engine-flutter-autoroll
6d44559 Remove the dummy rasterizer delegate now that flutter_runner …
6b2c829 
…is in tree, and cleanup ctor params (flutter/engine#20486)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2020
@engine-flutter-autoroll
6d44559 Remove the dummy rasterizer delegate now that flutter_runner …
9f41b4f 
…is in tree, and cleanup ctor params (flutter/engine#20486)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2020
@engine-flutter-autoroll
6d44559 Remove the dummy rasterizer delegate now that flutter_runner …
7a6bf70 
…is in tree, and cleanup ctor params (flutter/engine#20486)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2020
@engine-flutter-autoroll
6d44559 Remove the dummy rasterizer delegate now that flutter_runner …
3894b85 
…is in tree, and cleanup ctor params (flutter/engine#20486)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2020
@engine-flutter-autoroll
6d44559 Remove the dummy rasterizer delegate now that flutter_runner …
10f3fbc 
…is in tree, and cleanup ctor params (flutter/engine#20486)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 14, 2020
@engine-flutter-autoroll
6d44559 Remove the dummy rasterizer delegate now that flutter_runner …
e8a6515 
…is in tree, and cleanup ctor params (flutter/engine#20486)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 15, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 15, 2020
@engine-flutter-autoroll
6d44559 Remove the dummy rasterizer delegate now that flutter_runner …
22525dd 
…is in tree, and cleanup ctor params (flutter/engine#20486)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 16, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 16, 2020
@engine-flutter-autoroll
6d44559 Remove the dummy rasterizer delegate now that flutter_runner …
1174f91 
…is in tree, and cleanup ctor params (flutter/engine#20486)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 16, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 16, 2020
@engine-flutter-autoroll
6d44559 Remove the dummy rasterizer delegate now that flutter_runner …
c46feca 
…is in tree, and cleanup ctor params (flutter/engine#20486)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 16, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 16, 2020
@engine-flutter-autoroll
6d44559 Remove the dummy rasterizer delegate now that flutter_runner …
8c44776 
…is in tree, and cleanup ctor params (flutter/engine#20486)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 16, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 16, 2020
@engine-flutter-autoroll
6d44559 Remove the dummy rasterizer delegate now that flutter_runner …
1fc8135 
…is in tree, and cleanup ctor params (flutter/engine#20486)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 17, 2020
@engine-flutter-autoroll
6d44559 Remove the dummy rasterizer delegate now that flutter_runner …
9e70911 
…is in tree, and cleanup ctor params (flutter/engine#20486)
dnfield pushed a commit to flutter/flutter that referenced this pull request Aug 17, 2020
@engine-flutter-autoroll
Roll Engine from 7571e7c to 613be92 (76 revisions) (#63979)
1e36d44 
* 94f5cf4 Roll Dart SDK from 1a1ab78dd6bc to 91e46dcbbbbd (4 revisions) (flutter/engine#20431)

* e0d5153 Make CkVertices a ManagedSkiaObject (flutter/engine#20421)

* 5161fd1 Roll Skia from 864562faf497 to b3f26441d191 (22 revisions) (flutter/engine#20447)

* 2ac5b34 Revert "Refactor initial route code (#19684)" (flutter/engine#20450)

* 5c8a626 Delete CSS paint code (flutter/engine#20426)

* 9f146b5 Add --unoptimied and --asan to Fuchsia builds (flutter/engine#20427)

* 4fb3ea8 Roll Dart SDK from 91e46dcbbbbd to abdfa80162c1 (3 revisions) (flutter/engine#20453)

* 4e21787 Roll Skia from b3f26441d191 to c95b589112f3 (12 revisions) (flutter/engine#20456)

* d49c94b Roll Fuchsia Mac SDK from us_8V5gGK... to ik9kEVW-J... (flutter/engine#20457)

* 2eebe4a Roll Fuchsia Linux SDK from vomfYvIJk... to xcu8qvX33... (flutter/engine#20458)

* debb30e Fix broken symbols on Fuchsia embedder (flutter/engine#20459)

* 2bc0bfd Send locale information in the macOS embedding (flutter/engine#20461)

* 651cb38 Roll Skia from c95b589112f3 to 652124c372e5 (4 revisions) (flutter/engine#20462)

* 95b2ebf Roll Dart SDK from abdfa80162c1 to 279a4b920da8 (1 revision) (flutter/engine#20463)

* de6810b Roll Skia from 652124c372e5 to 025843fad003 (1 revision) (flutter/engine#20467)

* 52c1ec6 Roll Dart SDK from 279a4b920da8 to 00016747ab48 (2 revisions) (flutter/engine#20471)

* 7d45e22 Roll Dart SDK from 00016747ab48 to 9ae3e22f1e53 (1 revision) (flutter/engine#20474)

* aa46011 Roll Fuchsia Mac SDK from ik9kEVW-J... to c9oMk4qlD... (flutter/engine#20476)

* 4746a93 Roll Skia from 025843fad003 to df9ed89229db (4 revisions) (flutter/engine#20478)

* dd2c5a1 Plumbing for setting domain network policy (flutter/engine#20218)

* f0955b0 Roll Fuchsia Linux SDK from xcu8qvX33... to AjjDqKkUV... (flutter/engine#20477)

* eef639c Roll Skia from df9ed89229db to 8dd1e22f4130 (2 revisions) (flutter/engine#20481)

* f1855fb Clean-up CanvasKit canvas sizing. (flutter/engine#20387)

* d9f00a3 Roll Skia from 8dd1e22f4130 to af36652766db (6 revisions) (flutter/engine#20484)

* 4a91bc8 Roll Dart SDK from 9ae3e22f1e53 to 6d15e04622c2 (1 revision) (flutter/engine#20483)

* f396418 Do not access members after calling ClearDartWrapper (flutter/engine#20465)

* dacd2d4 Roll Skia from af36652766db to cc01311cfc96 (4 revisions) (flutter/engine#20485)

* 9cd99d2 Add enabled flag for try builders (flutter/engine#20460)

* 0c504da Refactor initial route code take 2 (flutter/engine#20468)

* 6d44559 Remove the dummy rasterizer delegate now that flutter_runner is in tree, and cleanup ctor params (flutter/engine#20486)

* 16c328d Roll Skia from cc01311cfc96 to 9e77f20864d3 (6 revisions) (flutter/engine#20489)

* da3c9ff Fix unoptimized fuchsia builds (flutter/engine#20488)

* 9e30383 Roll Skia from 9e77f20864d3 to 311dd9d8474c (4 revisions) (flutter/engine#20493)

* f644d03 Add a service protocol for raster cache memory (flutter/engine#20466)

* 6685b31 Roll Skia from 311dd9d8474c to 283c230fa18a (2 revisions) (flutter/engine#20499)

* d6052c0 Roll Fuchsia Linux SDK from AjjDqKkUV... to -dcNYnqRy... (flutter/engine#20502)

* 022058f Roll Fuchsia Mac SDK from c9oMk4qlD... to B75vjVVwe... (flutter/engine#20504)

* 9c99bf7 Add missing nullable annotation (flutter/engine#20505)

* d4f6100 Roll Skia from 283c230fa18a to b6ce6baf7a7a (1 revision) (flutter/engine#20506)

* 84aa365 Fix the legacy EncodableValue codepaths (flutter/engine#20501)

* c3d03b7 Roll Skia from b6ce6baf7a7a to c184cf36092f (3 revisions) (flutter/engine#20507)

* 5aaebfc Roll Skia from c184cf36092f to 1cf2c8d6ec21 (1 revision) (flutter/engine#20509)

* 4899b1c Roll Skia from 1cf2c8d6ec21 to e219c7ed3754 (1 revision) (flutter/engine#20512)

* 0d83051 Roll Skia from e219c7ed3754 to c9c4e2e9efac (3 revisions) (flutter/engine#20513)

* 33015c6 hasStrings on Android (flutter/engine#20393)

* 7b1ee9f Roll Skia from c9c4e2e9efac to 166cd52cee64 (4 revisions) (flutter/engine#20515)

* b32a2a5 Make sure ios tests fail if they fail (flutter/engine#20518)

* 0cda293 Fixed the accessibility ios unit tests by sending in mock view (flutter/engine#20522)

* 9993228 Fix web_ui warnings flagged by the next Dart analyzer update (flutter/engine#20524)

* 169b22c Handle glfwGetPrimaryMonitor returning nullptr (flutter/engine#20523)

* 429675d Custom Gradle home and add .vpython file (flutter/engine#20425)

* 9333b7c Create PlatformView instance right after method channel call from Dart (flutter/engine#20500)

* f0ca3d2 Roll Fuchsia Linux SDK from -dcNYnqRy... to WXwJgZ7tK... (flutter/engine#20517)

* dbf7e83 Roll Skia from 166cd52cee64 to 01d016186340 (9 revisions) (flutter/engine#20519)

* 5a2bf6a Reland: "fuchsia: Remove dead code / break dependencies" (flutter/engine#20532)

* 1590fb2 Roll Fuchsia Mac SDK from B75vjVVwe... to tmHY285qa... (flutter/engine#20534)

* f60e836 Started stubbing in the FlutterView property of the mock (flutter/engine#20542)

* ac6442a Roll Fuchsia Linux SDK from WXwJgZ7tK... to t6BpwE-Ie... (flutter/engine#20539)

* 7d4b549 Roll Fuchsia Mac SDK from tmHY285qa... to 0ZIOLxuHh... (flutter/engine#20544)

* b300be3 Roll Dart SDK from 6d15e04622c2 to 302893b93170 (11 revisions) (flutter/engine#20545)

* 31a0e45 Roll Skia from 01d016186340 to a008b0fa8bbb (14 revisions) (flutter/engine#20546)

* ac8175f Only create raster_thread_merge when explicitly requested by the embedding platform (flutter/engine#20487)

* 8430fa1 Roll Fuchsia Linux SDK from t6BpwE-Ie... to TD-QSKxG8... (flutter/engine#20548)

* ddf253b Roll Fuchsia Mac SDK from 0ZIOLxuHh... to EEj2OHioI... (flutter/engine#20549)

* 7fa21a4 [windows] Expose the binary messenger from FlutterEngine (flutter/engine#20399)

* 3ebcde6 Revert "[windows] Expose the binary messenger from FlutterEngine (#20399)" (flutter/engine#20550)

* 3aff256 Enable iOS plumbing for network security and add tests (flutter/engine#20492)

* f74e427 Roll Dart SDK from 302893b93170 to 58a209093c38 (1 revision) (flutter/engine#20552)

* fb581b9 Roll Skia from a008b0fa8bbb to d882e93e416b (2 revisions) (flutter/engine#20553)

* 219fc83 Roll Skia from d882e93e416b to c4245f475be7 (2 revisions) (flutter/engine#20554)

* 2116ed2 Roll Fuchsia Mac SDK from EEj2OHioI... to ko0N4Pxl_... (flutter/engine#20555)

* 76d4922 Roll Fuchsia Linux SDK from TD-QSKxG8... to oNnqaiRXK... (flutter/engine#20556)

* 32b1b70 [windows] Expose the binary messenger from FlutterEngine (flutter/engine#20551)

* 9060913 Send locale information in the Windows embedding (flutter/engine#20455)

* d7510df Roll Dart SDK from 58a209093c38 to e74e4de7a430 (1 revision) (flutter/engine#20559)

* 613be92 Roll Skia from c4245f475be7 to fdbd50a8dc87 (4 revisions) (flutter/engine#20561)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 17, 2020
@engine-flutter-autoroll
6d44559 Remove the dummy rasterizer delegate now that flutter_runner …
74312e8 
…is in tree, and cleanup ctor params (flutter/engine#20486)
smadey pushed a commit to smadey/flutter that referenced this pull request Aug 27, 2020
@engine-flutter-autoroll @smadey
Roll Engine from 7571e7c to 613be92 (76 revisions) (flutter#63979)
e5867e4 
* 94f5cf4 Roll Dart SDK from 1a1ab78dd6bc to 91e46dcbbbbd (4 revisions) (flutter/engine#20431)

* e0d5153 Make CkVertices a ManagedSkiaObject (flutter/engine#20421)

* 5161fd1 Roll Skia from 864562faf497 to b3f26441d191 (22 revisions) (flutter/engine#20447)

* 2ac5b34 Revert "Refactor initial route code (flutter#19684)" (flutter/engine#20450)

* 5c8a626 Delete CSS paint code (flutter/engine#20426)

* 9f146b5 Add --unoptimied and --asan to Fuchsia builds (flutter/engine#20427)

* 4fb3ea8 Roll Dart SDK from 91e46dcbbbbd to abdfa80162c1 (3 revisions) (flutter/engine#20453)

* 4e21787 Roll Skia from b3f26441d191 to c95b589112f3 (12 revisions) (flutter/engine#20456)

* d49c94b Roll Fuchsia Mac SDK from us_8V5gGK... to ik9kEVW-J... (flutter/engine#20457)

* 2eebe4a Roll Fuchsia Linux SDK from vomfYvIJk... to xcu8qvX33... (flutter/engine#20458)

* debb30e Fix broken symbols on Fuchsia embedder (flutter/engine#20459)

* 2bc0bfd Send locale information in the macOS embedding (flutter/engine#20461)

* 651cb38 Roll Skia from c95b589112f3 to 652124c372e5 (4 revisions) (flutter/engine#20462)

* 95b2ebf Roll Dart SDK from abdfa80162c1 to 279a4b920da8 (1 revision) (flutter/engine#20463)

* de6810b Roll Skia from 652124c372e5 to 025843fad003 (1 revision) (flutter/engine#20467)

* 52c1ec6 Roll Dart SDK from 279a4b920da8 to 00016747ab48 (2 revisions) (flutter/engine#20471)

* 7d45e22 Roll Dart SDK from 00016747ab48 to 9ae3e22f1e53 (1 revision) (flutter/engine#20474)

* aa46011 Roll Fuchsia Mac SDK from ik9kEVW-J... to c9oMk4qlD... (flutter/engine#20476)

* 4746a93 Roll Skia from 025843fad003 to df9ed89229db (4 revisions) (flutter/engine#20478)

* dd2c5a1 Plumbing for setting domain network policy (flutter/engine#20218)

* f0955b0 Roll Fuchsia Linux SDK from xcu8qvX33... to AjjDqKkUV... (flutter/engine#20477)

* eef639c Roll Skia from df9ed89229db to 8dd1e22f4130 (2 revisions) (flutter/engine#20481)

* f1855fb Clean-up CanvasKit canvas sizing. (flutter/engine#20387)

* d9f00a3 Roll Skia from 8dd1e22f4130 to af36652766db (6 revisions) (flutter/engine#20484)

* 4a91bc8 Roll Dart SDK from 9ae3e22f1e53 to 6d15e04622c2 (1 revision) (flutter/engine#20483)

* f396418 Do not access members after calling ClearDartWrapper (flutter/engine#20465)

* dacd2d4 Roll Skia from af36652766db to cc01311cfc96 (4 revisions) (flutter/engine#20485)

* 9cd99d2 Add enabled flag for try builders (flutter/engine#20460)

* 0c504da Refactor initial route code take 2 (flutter/engine#20468)

* 6d44559 Remove the dummy rasterizer delegate now that flutter_runner is in tree, and cleanup ctor params (flutter/engine#20486)

* 16c328d Roll Skia from cc01311cfc96 to 9e77f20864d3 (6 revisions) (flutter/engine#20489)

* da3c9ff Fix unoptimized fuchsia builds (flutter/engine#20488)

* 9e30383 Roll Skia from 9e77f20864d3 to 311dd9d8474c (4 revisions) (flutter/engine#20493)

* f644d03 Add a service protocol for raster cache memory (flutter/engine#20466)

* 6685b31 Roll Skia from 311dd9d8474c to 283c230fa18a (2 revisions) (flutter/engine#20499)

* d6052c0 Roll Fuchsia Linux SDK from AjjDqKkUV... to -dcNYnqRy... (flutter/engine#20502)

* 022058f Roll Fuchsia Mac SDK from c9oMk4qlD... to B75vjVVwe... (flutter/engine#20504)

* 9c99bf7 Add missing nullable annotation (flutter/engine#20505)

* d4f6100 Roll Skia from 283c230fa18a to b6ce6baf7a7a (1 revision) (flutter/engine#20506)

* 84aa365 Fix the legacy EncodableValue codepaths (flutter/engine#20501)

* c3d03b7 Roll Skia from b6ce6baf7a7a to c184cf36092f (3 revisions) (flutter/engine#20507)

* 5aaebfc Roll Skia from c184cf36092f to 1cf2c8d6ec21 (1 revision) (flutter/engine#20509)

* 4899b1c Roll Skia from 1cf2c8d6ec21 to e219c7ed3754 (1 revision) (flutter/engine#20512)

* 0d83051 Roll Skia from e219c7ed3754 to c9c4e2e9efac (3 revisions) (flutter/engine#20513)

* 33015c6 hasStrings on Android (flutter/engine#20393)

* 7b1ee9f Roll Skia from c9c4e2e9efac to 166cd52cee64 (4 revisions) (flutter/engine#20515)

* b32a2a5 Make sure ios tests fail if they fail (flutter/engine#20518)

* 0cda293 Fixed the accessibility ios unit tests by sending in mock view (flutter/engine#20522)

* 9993228 Fix web_ui warnings flagged by the next Dart analyzer update (flutter/engine#20524)

* 169b22c Handle glfwGetPrimaryMonitor returning nullptr (flutter/engine#20523)

* 429675d Custom Gradle home and add .vpython file (flutter/engine#20425)

* 9333b7c Create PlatformView instance right after method channel call from Dart (flutter/engine#20500)

* f0ca3d2 Roll Fuchsia Linux SDK from -dcNYnqRy... to WXwJgZ7tK... (flutter/engine#20517)

* dbf7e83 Roll Skia from 166cd52cee64 to 01d016186340 (9 revisions) (flutter/engine#20519)

* 5a2bf6a Reland: "fuchsia: Remove dead code / break dependencies" (flutter/engine#20532)

* 1590fb2 Roll Fuchsia Mac SDK from B75vjVVwe... to tmHY285qa... (flutter/engine#20534)

* f60e836 Started stubbing in the FlutterView property of the mock (flutter/engine#20542)

* ac6442a Roll Fuchsia Linux SDK from WXwJgZ7tK... to t6BpwE-Ie... (flutter/engine#20539)

* 7d4b549 Roll Fuchsia Mac SDK from tmHY285qa... to 0ZIOLxuHh... (flutter/engine#20544)

* b300be3 Roll Dart SDK from 6d15e04622c2 to 302893b93170 (11 revisions) (flutter/engine#20545)

* 31a0e45 Roll Skia from 01d016186340 to a008b0fa8bbb (14 revisions) (flutter/engine#20546)

* ac8175f Only create raster_thread_merge when explicitly requested by the embedding platform (flutter/engine#20487)

* 8430fa1 Roll Fuchsia Linux SDK from t6BpwE-Ie... to TD-QSKxG8... (flutter/engine#20548)

* ddf253b Roll Fuchsia Mac SDK from 0ZIOLxuHh... to EEj2OHioI... (flutter/engine#20549)

* 7fa21a4 [windows] Expose the binary messenger from FlutterEngine (flutter/engine#20399)

* 3ebcde6 Revert "[windows] Expose the binary messenger from FlutterEngine (flutter#20399)" (flutter/engine#20550)

* 3aff256 Enable iOS plumbing for network security and add tests (flutter/engine#20492)

* f74e427 Roll Dart SDK from 302893b93170 to 58a209093c38 (1 revision) (flutter/engine#20552)

* fb581b9 Roll Skia from a008b0fa8bbb to d882e93e416b (2 revisions) (flutter/engine#20553)

* 219fc83 Roll Skia from d882e93e416b to c4245f475be7 (2 revisions) (flutter/engine#20554)

* 2116ed2 Roll Fuchsia Mac SDK from EEj2OHioI... to ko0N4Pxl_... (flutter/engine#20555)

* 76d4922 Roll Fuchsia Linux SDK from TD-QSKxG8... to oNnqaiRXK... (flutter/engine#20556)

* 32b1b70 [windows] Expose the binary messenger from FlutterEngine (flutter/engine#20551)

* 9060913 Send locale information in the Windows embedding (flutter/engine#20455)

* d7510df Roll Dart SDK from 58a209093c38 to e74e4de7a430 (1 revision) (flutter/engine#20559)

* 613be92 Roll Skia from c4245f475be7 to fdbd50a8dc87 (4 revisions) (flutter/engine#20561)
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@engine-flutter-autoroll @mingwandroid
Roll Engine from 7571e7c to 613be92 (76 revisions) (flutter#63979)
1d03488 
* 94f5cf4 Roll Dart SDK from 1a1ab78dd6bc to 91e46dcbbbbd (4 revisions) (flutter/engine#20431)

* e0d5153 Make CkVertices a ManagedSkiaObject (flutter/engine#20421)

* 5161fd1 Roll Skia from 864562faf497 to b3f26441d191 (22 revisions) (flutter/engine#20447)

* 2ac5b34 Revert "Refactor initial route code (flutter#19684)" (flutter/engine#20450)

* 5c8a626 Delete CSS paint code (flutter/engine#20426)

* 9f146b5 Add --unoptimied and --asan to Fuchsia builds (flutter/engine#20427)

* 4fb3ea8 Roll Dart SDK from 91e46dcbbbbd to abdfa80162c1 (3 revisions) (flutter/engine#20453)

* 4e21787 Roll Skia from b3f26441d191 to c95b589112f3 (12 revisions) (flutter/engine#20456)

* d49c94b Roll Fuchsia Mac SDK from us_8V5gGK... to ik9kEVW-J... (flutter/engine#20457)

* 2eebe4a Roll Fuchsia Linux SDK from vomfYvIJk... to xcu8qvX33... (flutter/engine#20458)

* debb30e Fix broken symbols on Fuchsia embedder (flutter/engine#20459)

* 2bc0bfd Send locale information in the macOS embedding (flutter/engine#20461)

* 651cb38 Roll Skia from c95b589112f3 to 652124c372e5 (4 revisions) (flutter/engine#20462)

* 95b2ebf Roll Dart SDK from abdfa80162c1 to 279a4b920da8 (1 revision) (flutter/engine#20463)

* de6810b Roll Skia from 652124c372e5 to 025843fad003 (1 revision) (flutter/engine#20467)

* 52c1ec6 Roll Dart SDK from 279a4b920da8 to 00016747ab48 (2 revisions) (flutter/engine#20471)

* 7d45e22 Roll Dart SDK from 00016747ab48 to 9ae3e22f1e53 (1 revision) (flutter/engine#20474)

* aa46011 Roll Fuchsia Mac SDK from ik9kEVW-J... to c9oMk4qlD... (flutter/engine#20476)

* 4746a93 Roll Skia from 025843fad003 to df9ed89229db (4 revisions) (flutter/engine#20478)

* dd2c5a1 Plumbing for setting domain network policy (flutter/engine#20218)

* f0955b0 Roll Fuchsia Linux SDK from xcu8qvX33... to AjjDqKkUV... (flutter/engine#20477)

* eef639c Roll Skia from df9ed89229db to 8dd1e22f4130 (2 revisions) (flutter/engine#20481)

* f1855fb Clean-up CanvasKit canvas sizing. (flutter/engine#20387)

* d9f00a3 Roll Skia from 8dd1e22f4130 to af36652766db (6 revisions) (flutter/engine#20484)

* 4a91bc8 Roll Dart SDK from 9ae3e22f1e53 to 6d15e04622c2 (1 revision) (flutter/engine#20483)

* f396418 Do not access members after calling ClearDartWrapper (flutter/engine#20465)

* dacd2d4 Roll Skia from af36652766db to cc01311cfc96 (4 revisions) (flutter/engine#20485)

* 9cd99d2 Add enabled flag for try builders (flutter/engine#20460)

* 0c504da Refactor initial route code take 2 (flutter/engine#20468)

* 6d44559 Remove the dummy rasterizer delegate now that flutter_runner is in tree, and cleanup ctor params (flutter/engine#20486)

* 16c328d Roll Skia from cc01311cfc96 to 9e77f20864d3 (6 revisions) (flutter/engine#20489)

* da3c9ff Fix unoptimized fuchsia builds (flutter/engine#20488)

* 9e30383 Roll Skia from 9e77f20864d3 to 311dd9d8474c (4 revisions) (flutter/engine#20493)

* f644d03 Add a service protocol for raster cache memory (flutter/engine#20466)

* 6685b31 Roll Skia from 311dd9d8474c to 283c230fa18a (2 revisions) (flutter/engine#20499)

* d6052c0 Roll Fuchsia Linux SDK from AjjDqKkUV... to -dcNYnqRy... (flutter/engine#20502)

* 022058f Roll Fuchsia Mac SDK from c9oMk4qlD... to B75vjVVwe... (flutter/engine#20504)

* 9c99bf7 Add missing nullable annotation (flutter/engine#20505)

* d4f6100 Roll Skia from 283c230fa18a to b6ce6baf7a7a (1 revision) (flutter/engine#20506)

* 84aa365 Fix the legacy EncodableValue codepaths (flutter/engine#20501)

* c3d03b7 Roll Skia from b6ce6baf7a7a to c184cf36092f (3 revisions) (flutter/engine#20507)

* 5aaebfc Roll Skia from c184cf36092f to 1cf2c8d6ec21 (1 revision) (flutter/engine#20509)

* 4899b1c Roll Skia from 1cf2c8d6ec21 to e219c7ed3754 (1 revision) (flutter/engine#20512)

* 0d83051 Roll Skia from e219c7ed3754 to c9c4e2e9efac (3 revisions) (flutter/engine#20513)

* 33015c6 hasStrings on Android (flutter/engine#20393)

* 7b1ee9f Roll Skia from c9c4e2e9efac to 166cd52cee64 (4 revisions) (flutter/engine#20515)

* b32a2a5 Make sure ios tests fail if they fail (flutter/engine#20518)

* 0cda293 Fixed the accessibility ios unit tests by sending in mock view (flutter/engine#20522)

* 9993228 Fix web_ui warnings flagged by the next Dart analyzer update (flutter/engine#20524)

* 169b22c Handle glfwGetPrimaryMonitor returning nullptr (flutter/engine#20523)

* 429675d Custom Gradle home and add .vpython file (flutter/engine#20425)

* 9333b7c Create PlatformView instance right after method channel call from Dart (flutter/engine#20500)

* f0ca3d2 Roll Fuchsia Linux SDK from -dcNYnqRy... to WXwJgZ7tK... (flutter/engine#20517)

* dbf7e83 Roll Skia from 166cd52cee64 to 01d016186340 (9 revisions) (flutter/engine#20519)

* 5a2bf6a Reland: "fuchsia: Remove dead code / break dependencies" (flutter/engine#20532)

* 1590fb2 Roll Fuchsia Mac SDK from B75vjVVwe... to tmHY285qa... (flutter/engine#20534)

* f60e836 Started stubbing in the FlutterView property of the mock (flutter/engine#20542)

* ac6442a Roll Fuchsia Linux SDK from WXwJgZ7tK... to t6BpwE-Ie... (flutter/engine#20539)

* 7d4b549 Roll Fuchsia Mac SDK from tmHY285qa... to 0ZIOLxuHh... (flutter/engine#20544)

* b300be3 Roll Dart SDK from 6d15e04622c2 to 302893b93170 (11 revisions) (flutter/engine#20545)

* 31a0e45 Roll Skia from 01d016186340 to a008b0fa8bbb (14 revisions) (flutter/engine#20546)

* ac8175f Only create raster_thread_merge when explicitly requested by the embedding platform (flutter/engine#20487)

* 8430fa1 Roll Fuchsia Linux SDK from t6BpwE-Ie... to TD-QSKxG8... (flutter/engine#20548)

* ddf253b Roll Fuchsia Mac SDK from 0ZIOLxuHh... to EEj2OHioI... (flutter/engine#20549)

* 7fa21a4 [windows] Expose the binary messenger from FlutterEngine (flutter/engine#20399)

* 3ebcde6 Revert "[windows] Expose the binary messenger from FlutterEngine (flutter#20399)" (flutter/engine#20550)

* 3aff256 Enable iOS plumbing for network security and add tests (flutter/engine#20492)

* f74e427 Roll Dart SDK from 302893b93170 to 58a209093c38 (1 revision) (flutter/engine#20552)

* fb581b9 Roll Skia from a008b0fa8bbb to d882e93e416b (2 revisions) (flutter/engine#20553)

* 219fc83 Roll Skia from d882e93e416b to c4245f475be7 (2 revisions) (flutter/engine#20554)

* 2116ed2 Roll Fuchsia Mac SDK from EEj2OHioI... to ko0N4Pxl_... (flutter/engine#20555)

* 76d4922 Roll Fuchsia Linux SDK from TD-QSKxG8... to oNnqaiRXK... (flutter/engine#20556)

* 32b1b70 [windows] Expose the binary messenger from FlutterEngine (flutter/engine#20551)

* 9060913 Send locale information in the Windows embedding (flutter/engine#20455)

* d7510df Roll Dart SDK from 58a209093c38 to e74e4de7a430 (1 revision) (flutter/engine#20559)

* 613be92 Roll Skia from c4245f475be7 to fdbd50a8dc87 (4 revisions) (flutter/engine#20561)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

@iskakaushik iskakaushik Awaiting requested review from iskakaushik

@gaaclarke gaaclarke Awaiting requested review from gaaclarke

@liyuqian liyuqian Awaiting requested review from liyuqian

Assignees
No one assigned
Labels
cla: yes platform-android platform-fuchsia platform-ios waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
4 participants
@dnfield @chinmaygarde @googlebot @fluttergithubbot