New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fuchsia: Don't send ViewportMetrics w/ 0 DPR #21392
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
I think you should be able to add a test for this modeled on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like Dans idea of using the optionals as ivars.
@arbreng Can we land this now please |
70b2379
to
c49d965
Compare
c49d965
to
cdf6548
Compare
Description
The Fuchsia embedder is sometimes sending 0 for the DPR when it shouldn't be. Recitfy this.
Related Issues
https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=60299
Tests
Added new test case in platform_view_unittests.