Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flutter_releases] Flutter 1.22.1 Engine Cherrypicks #21669

Merged
merged 5 commits into from Oct 7, 2020
Merged

[flutter_releases] Flutter 1.22.1 Engine Cherrypicks #21669

merged 5 commits into from Oct 7, 2020

Conversation

christopherfujino
Copy link
Member

@christopherfujino christopherfujino commented Oct 7, 2020 •
edited

Scheduled Cherrypicks

  • Dart 2.10.1
  • [Add2App] Android causes exceptions when launching a Flutter Activity for the first time on some versions of Android #66908
  • iOS 14 crash -- Fatal Exception: NSInternalInconsistencyException Modifications to the layout engine must not be performed from a background thread after it has been accessed from the main thread. #66647

Known failures

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@google-cla google-cla bot added the cla: yes label Oct 7, 2020
jason-simmons and others added 2 commits October 7, 2020 12:06
@jason-simmons @christopherfujino
Extract the WindowInsetsAnimation.Callback subclass into a separate c…
ba6dfc6 
…lass that will be lazily loaded (flutter#21548)

WindowInsetsAnimation.Callback was introduced in API level 30.  This
PR moves the text input plugin's WindowInsetsAnimation.Callback subclass
into a class that will only be loaded if the embedding has checked for a
sufficient API level.

See flutter/flutter#66908
@christopherfujino
iOS: only add explicit transactions when there are platform views (on…
2d54b49 
…ly on main threads) (flutter#21526)
@christopherfujino christopherfujino marked this pull request as ready for review October 7, 2020 19:20
@christopherfujino christopherfujino changed the title Update Dart to 2.10.1 [flutter_releases] Flutter 1.20.1 Engine Cherrypicks Oct 7, 2020
@christopherfujino christopherfujino changed the title [flutter_releases] Flutter 1.20.1 Engine Cherrypicks [flutter_releases] Flutter 1.22.1 Engine Cherrypicks Oct 7, 2020
@christopherfujino
Copy link
Member Author

Landing this TBR by @pcsosinski

@christopherfujino christopherfujino merged commit 75bef9f into flutter:flutter-1.22-candidate.12 Oct 7, 2020
@christopherfujino christopherfujino deleted the flutter-1.22-candidate.12 branch October 7, 2020 22:34
pcsosinski
pcsosinski reviewed Oct 7, 2020
View reviewed changes
Copy link

@pcsosinski pcsosinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for branch

@christopherfujino christopherfujino mentioned this pull request Oct 14, 2020
Merged
@pcsosinski pcsosinski mentioned this pull request Nov 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcsosinski pcsosinski pcsosinski left review comments

@jason-simmons jason-simmons Awaiting requested review from jason-simmons

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

Assignees
No one assigned
Labels
cla: yes platform-android platform-ios
Projects
None yet
Milestone
No milestone
3 participants
@christopherfujino @pcsosinski @jason-simmons