[fuchsia] Adds a test for timezone change #21934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iskakaushik Please take a look? |
This is a Fuchsia-only shell test, confirming that when the timezone setting is changed on the realm via Fuchsia's FIDL interface `fuchsia.settings.Intl`, the Dart isolate running in that realm receives the change and starts reporting the appropriate timestamp. We already have a [similar test][tst] that verifies the timezones in the dart VM matches the local timezone at start, but there was no test that also verified timezone changes. [tst]: https://github.com/flutter/engine/blob/master/shell/common/shell_unittests.cc#L1166 The test has been ran 1000 times on fuchsia to check for flakiness, and it passed. Tested: ``` fx shell run \ fuchsia-pkg://fuchsia.com/shell_tests#meta/shell_tests.cmx \ --gtest_filter="*Fuchsia*" --gtest_repeat=1000 ``` See issue #61284
filmil
force-pushed
the
timezone-change-test-against-HEAD
branch
from
dcbdfd9
to
7f8f69a
Compare
|
@chinmaygarde PTAL? Added a test to guard timezone change on Fuchsia. |
chinmaygarde
approved these changes
Oct 24, 2020
|
Thank you! Will this need a manual merge? |
chinmaygarde
added
the
waiting for tree to go green
|
I don't think so. I added the tag for the bot to autoland it when the tree goes green. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 24, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 24, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 24, 2020
chaselatta
pushed a commit
to chaselatta/engine
that referenced
this pull request
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a Fuchsia-only shell test, confirming that when the timezone
setting is changed on the realm via Fuchsia's FIDL interface
fuchsia.settings.Intl, the Dart isolate running in that realm receivesthe change and starts reporting the appropriate timestamp.
We already have a similar test that verifies the timezones in the
dart VM matches the local timezone at start, but there was no test that
also verified timezone changes.
The test has been ran 1000 times on fuchsia to check for flakiness,
and it passed.
Related Issues
Tests
I added the following tests:
FuchsiaShellTest.LocaltimesVaryOnTimezoneChangesTested:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Reviewer Checklist
Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.