Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine null-safety isolate flags for launches of the service isolate. #22013

Merged
merged 2 commits into from Oct 20, 2020
Merged

Determine null-safety isolate flags for launches of the service isolate. #22013

merged 2 commits into from Oct 20, 2020

Commits on Oct 20, 2020

  1. Determine null-safety isolate flags for launches of the service isolate. 

    Previously, there was as assumption was that the service isolate launch flags
would be inherited from the parent isolate (the root isolate). This does not
seem to be the case the isolate launch flags must specify the null-safety
characteristics. Since the application kernel for the service isolate is not
available, it is unclear of the VM is able to determine the same from the
isolate snapshot. The added test seems to indicate that it does. However, it
would be good to get a clarification from the VM team as to weather this usage
is correct.

Fixes flutter/flutter#68561
    @chinmaygarde
    chinmaygarde committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    47469cf View commit details
    Browse the repository at this point in the history

  2. Address Siva's PR comments.

    @chinmaygarde
    chinmaygarde committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    370bbd3 View commit details
    Browse the repository at this point in the history