[web] Speed up PageView/CustomPainter rendering #22408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
approved these changes
Nov 10, 2020
| /// | ||
| /// Used for web optimization of physical shape represented as | ||
| /// a persistent div. | ||
| ui.Rect? get webOnlyPathAsLine => pathRef.getLine(); |
There was a problem hiding this comment.
This doesn't need the webOnly prefix as it's in the private _engine library.
| } | ||
|
|
||
| /// Returns horizontal/vertical line bounds or null if not a line. | ||
| ui.Rect? getLine() { |
There was a problem hiding this comment.
I'd give it a more specific name. When I read the call site I was immediately confused "What if the line is neither horizontal nor vertical?"
| if ((x2 - x3) != width || (y3 - y0) != height) { | ||
| return null; | ||
| } | ||
| return ui.Rect.fromLTWH(x0, y0, width, height); |
There was a problem hiding this comment.
Do we need to check that the path is closed?
There was a problem hiding this comment.
Added warning to API, not to use for strokes only fills/clips.
| final double y0 = atPoint(0).dy; | ||
| final double x1 = atPoint(1).dx; | ||
| final double y1 = atPoint(1).dy; | ||
| if (_fVerbs[1] != SPath.kLineVerb || y1 != y0) { |
There was a problem hiding this comment.
Do we only detect rects that begin with a horizontal border?
There was a problem hiding this comment.
yes. added comment.
| @@ -1537,6 +1537,12 @@ class SurfacePath implements ui.Path { | |||
| /// a persistent div. | |||
| ui.Rect? get webOnlyPathAsRect => pathRef.getRect(); | |||
|
|
|||
| /// Detects if path is a vertical or horizontal line returns LTRB or null. | |||
There was a problem hiding this comment.
nit: "... line. Returns ..."
yjbanov
approved these changes
Nov 10, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 11, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 11, 2020
chaselatta
pushed a commit
to chaselatta/engine
that referenced
this pull request
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Speed up PageView/CustomPainter rendering.
bench_page_view_scroll_line_through.html.drawFrameDuration.average 2.63x
bench_page_view_scroll_line_through.html.drawFrameDuration.outlierRatio 1.46x
bench_page_view_scroll_line_through.html.totalUiFrame.average 3.29x
Other benchmarks are in 1.0 to 1.07x range.
Related Issues
flutter/flutter#65824
flutter/flutter#62596
Tests
I added the following tests:
page_test.dart
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Reviewer Checklist
Breaking Change
Did any tests fail when you ran them? Please read [handling breaking changes].