Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web] Fix flake due to shadow rendering difference on webkit #23961

Merged
merged 3 commits into from Jan 27, 2021
Merged

[web] Fix flake due to shadow rendering difference on webkit #23961

merged 3 commits into from Jan 27, 2021

Conversation

ferhatb
Copy link
Contributor

@ferhatb ferhatb commented Jan 26, 2021

Related flake issue: flutter/flutter#74702
2nd flake is due to shadow rendering in Safari.
Added TODO for first flake to investigate large jump in delta in flake and increased maxDiff to prevent failure for webkit only.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ferhatb ferhatb requested a review from yjbanov January 26, 2021 17:29
yjbanov
yjbanov approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ferhatb ferhatb added platform-web Code specifically for the web engine waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. labels Jan 27, 2021
@fluttergithubbot fluttergithubbot merged commit 7ffca99 into flutter:master Jan 27, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 27, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 27, 2021
@engine-flutter-autoroll
7ffca99 Fix flake due to shadow rendering difference on webkit (flutt…
e2d350d 
…er/engine#23961)
@ferhatb ferhatb deleted the deflake branch February 11, 2021 17:42
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@ferhatb @hjfreyer
Fix flake due to shadow rendering difference on webkit (flutter#23961)
096304f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yjbanov yjbanov yjbanov approved these changes

Assignees
No one assigned
Labels
cla: yes platform-web Code specifically for the web engine waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
4 participants
@ferhatb @yjbanov @googlebot @fluttergithubbot