[web] Fix text rendering issue when paragraph style is ginormous #24159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdebbar
force-pushed
the
fix_paragraph_height
branch
from
82c5fba
to
2e86dd9
Compare
ferhatb
approved these changes
Feb 3, 2021
mdebbar
force-pushed
the
fix_paragraph_height
branch
from
066970f
to
708cefd
Compare
mdebbar
force-pushed
the
fix_paragraph_height
branch
from
708cefd
to
23fedbe
Compare
mdebbar
added
the
waiting for tree to go green
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 10, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 11, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 11, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 11, 2021
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a paragraph has ginormous styles (e.g.
fontSize=48.0) but all spans have small styles (e.g.fontStyle=14.0) this causes theDomCanvasto render the paragraph incorrectly. The<p>element has the huge font size which affects the layout of the paragraph, even though none of its children inherits the huge font size.Since all spans already set their own font size (they inherit from the paragraph style if necessary), there's no need to set these CSS properties at the paragraph level anyway.
Goldens PR: flutter/goldens#157
Fixes the HTML renderer part of flutter/flutter#74721