Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[metal] Darwin unified external metal textures" #24223

Merged
merged 1 commit into from Feb 5, 2021

Conversation

zanderso
Copy link
Member

@zanderso zanderso commented Feb 5, 2021

Reverts #24157

Speculating that this is the cause of flutter/flutter#75457 in the roll at flutter/flutter#75450

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Feb 5, 2021
@iskakaushik iskakaushik merged commit 30bb5f1 into master Feb 5, 2021
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@cbracken cbracken deleted the revert-24157-darwin_external_textures branch May 10, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants