Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix windows debug builds #25387

Merged
merged 2 commits into from Apr 3, 2021
Merged

Fix windows debug builds #25387

merged 2 commits into from Apr 3, 2021

Conversation

clarkezone
Copy link
Contributor

Missing header in angle_surface_manager.h causing debug builds to fail.

flutter/flutter#76132

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@clarkezone clarkezone self-assigned this Apr 2, 2021
@google-cla google-cla bot added the cla: yes label Apr 2, 2021
@clarkezone clarkezone merged commit e988a3b into flutter:master Apr 3, 2021
cbracken
cbracken reviewed Apr 3, 2021
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 3, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 3, 2021
@engine-flutter-autoroll
e988a3b Fix windows debug builds (flutter/engine#25387)
d53073a
duanqz pushed a commit to duanqz/engine that referenced this pull request Apr 16, 2021
@clarkezone @duanqz
Fix windows debug builds (flutter#25387)
9deb370
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbracken cbracken cbracken left review comments

@gw280 gw280 gw280 approved these changes

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

Assignees

@clarkezone clarkezone

Labels
cla: yes
Projects
None yet
Milestone
No milestone
3 participants
@clarkezone @cbracken @gw280