Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate tests to nullsafe #25620

Merged
merged 8 commits into from Apr 17, 2021
Merged

migrate tests to nullsafe #25620

merged 8 commits into from Apr 17, 2021

Conversation

ferhatb
Copy link
Contributor

@ferhatb ferhatb commented Apr 16, 2021

flutter/flutter#80533

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the [engine presubmit flakes form] before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on [Discord].

@ferhatb ferhatb requested a review from mdebbar April 16, 2021 00:22
@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Apr 16, 2021
@google-cla google-cla bot added the cla: yes label Apr 16, 2021
Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up to all the "checkScreenshot" functions!

Comment on lines +28 to +30
for (html.Node scene in html.document.querySelectorAll('flt-scene')) {
scene.remove();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary now that sceneScreenshot does the removal?

Co-authored-by: Mouad Debbar <mouad.debbar@gmail.com>
@google-cla
Copy link

google-cla bot commented Apr 16, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Apr 16, 2021
@ferhatb ferhatb merged commit aa8a64b into flutter:master Apr 17, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 18, 2021
GuoXi pushed a commit to GuoXi/engine that referenced this pull request Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes platform-web Code specifically for the web engine
Projects
None yet
3 participants