Fix crash when FlutterFragmentActivity is recreated with an existing FlutterFragment #25770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xster
requested review from
gaaclarke and
GaryQian
and removed request for
blasten
gaaclarke
approved these changes
Apr 26, 2021
| static class FlutterFragmentActivityWithProvidedEngine extends FlutterFragmentActivity { | ||
| int engineCreated = 0; |
There was a problem hiding this comment.
s/engineCreated/numberOfEnginesCreated
xster
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 27, 2021
…xisting FlutterFragment (flutter/engine#25770)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes b/186281005. I broke it in https://github.com/flutter/engine/pull/25395/files#diff-893547c230a70f1b0618f0b79a56c67d8506f0983a5a92b819f13c1071fd7d84R591 since there's an edge case where that method is called before the FlutterFragmentActivity figures out which FlutterFragment it contains in scenarios where the FlutterFragmentActivity is destroyed (such as during reconfiguration) but the FlutterFragment in the fragment manager is not.
This PR moves the restore of the existing fragment earlier in the FlutterFragmentActivity recreation process.