Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tools/gn compatible with Python 3 #26321

Merged
merged 1 commit into from
May 21, 2021
Merged

Conversation

cbracken
Copy link
Member

Python 2.7 was end-of-lifed on 2020-01-01. This makes tools/gn
compatible with both Python 2.7 and Python 3.

One in a series of fixes for flutter/flutter#83043

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Python 2.7 was end-of-lifed on 2020-01-01. This makes tools/gn
compatible with both Python 2.7 and Python 3.

Issue: flutter/flutter#83043
@cbracken
Copy link
Member Author

/cc @godofredoc, since I'm not sure what the plan for Python migration on the bots is.

@godofredoc
Copy link
Contributor

godofredoc commented May 21, 2021

/cc @godofredoc, since I'm not sure what the plan for Python migration on the bots is.

python in the bots is provided as a cipd package and added to the path. The difference is that we may need to explicitly use python3 to run them instead of just python.

@cbracken cbracken added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 21, 2021
@cbracken cbracken merged commit 27e2ca7 into flutter:master May 21, 2021
@cbracken cbracken deleted the gn-python3 branch May 21, 2021 17:58
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
3 participants