Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS: Do not send key event if modifiers flags haven't changed #26347

Merged
merged 3 commits into from May 23, 2021

Conversation

knopp
Copy link
Member

@knopp knopp commented May 22, 2021

Fixes flutter/flutter#77535

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@dkwingsmt
Copy link
Contributor

Looks good, can you add a unit test?

@knopp knopp force-pushed the macos_no_key_event_with_same_flags branch from af479bd to 66c040c Compare May 23, 2021 08:48
@knopp
Copy link
Member Author

knopp commented May 23, 2021

@dkwingsmt, I added a test for this. I also noticed that FlutterViewControllerTest tests fail (unrelated to this PR), do you happen to know why? Is this expected?

@dkwingsmt
Copy link
Contributor

It's a very weird error... can you try sync'ing with master?

@knopp knopp force-pushed the macos_no_key_event_with_same_flags branch from 66c040c to df7bed4 Compare May 23, 2021 12:00
@knopp
Copy link
Member Author

knopp commented May 23, 2021

@dkwingsmt, I rebased the PR and the checks are now passing.

Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knopp knopp merged commit 2616d40 into flutter:master May 23, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 23, 2021
@knopp knopp deleted the macos_no_key_event_with_same_flags branch July 17, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants