New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Flutter focus to interop with Android view hierarchies #26602
Conversation
VD_PLATFORM_VIEW, | ||
// InputConnection is managed by an embedded platform view that is embeded in the Android view | ||
// hierarchy. | ||
HC_PLATFORM_VIEW, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is HC
meant to stand for "hierarchy"? Not sure if this is a standard abbreviation, but it was not intuitive for me. It may be clearer to just write it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I clarified it in the comment above.
shell/platform/android/io/flutter/plugin/editing/TextInputPlugin.java
Outdated
Show resolved
Hide resolved
shell/platform/android/io/flutter/plugin/editing/TextInputPlugin.java
Outdated
Show resolved
Hide resolved
shell/platform/android/io/flutter/plugin/editing/TextInputPlugin.java
Outdated
Show resolved
Hide resolved
shell/platform/android/io/flutter/embedding/engine/systemchannels/TextInputChannel.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % a few nits.
FYI, we believe this change is causing thousands of crashes on our app. You cannot register a
We have a short-term mitigation, but the issue needs to be fixed ASAP. |
@math1man thanks. working on the fix right now |
Sweet |
When platform views are used in the Flutter widget tree, the keyboard may be dismissed or shown incorrectly.
The issue was present in hybrid composition too. When HC is used, this issue can be solved by checking
if any descendant view of the current platform view has been focused.
Fixes flutter/flutter#81029
Fixes flutter/flutter#34169 for HC.
This PR will also close flutter/flutter#34169 since using HC is the solution.
screen-20210605-120831_2.mp4